From 3fe485213347980c458e52546b07ac3ad8f2d3ae Mon Sep 17 00:00:00 2001
From: James Christian Ruiz <125330341+plvzfq-rit@users.noreply.github.com>
Date: Tue, 1 Oct 2024 23:50:46 +0800
Subject: [PATCH] Change instances of 'Search Selected' to 'Search
 Pre-configured' (#11871)

* Change instances of 'Search Selected' to 'Search Pre-configured'

Instances of 'Search Selected' has been changed to 'Search Pre-configured' in the following files:
- CompositeSearchBasedFetcher.java in line 21
- JabRef_en.properties in line 128
- WebFetchers.java in line 241
- WebSearchTab.fxml in line 30

* Update CHANGELOG.md

Update CHANGELOG.md to reflect Web Search Preferences UI changes from 'Search Selected' to 'Search Pre-configured'

* Make 'Pre-configured' lowercase

* Revert name changes in logic modules

Revert 'Search pre-configured' back to 'Search Selected' to stop errors

* Revert name reverts in logic modules

Revert 'Search Selected' back to 'Search pre-configured' since not doing so does not update dropdown menu
---
 CHANGELOG.md                                                    | 1 +
 .../java/org/jabref/gui/preferences/websearch/WebSearchTab.fxml | 2 +-
 src/main/java/org/jabref/logic/importer/WebFetchers.java        | 2 +-
 .../logic/importer/fetcher/CompositeSearchBasedFetcher.java     | 2 +-
 src/main/resources/l10n/JabRef_en.properties                    | 2 +-
 5 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e1da7f61956..52105585c0f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -53,6 +53,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We improved the DOI detection in PDF imports. [#11782](https://github.com/JabRef/jabref/pull/11782)
 - We improved the performance when pasting and importing entries in an existing library. [#11843](https://github.com/JabRef/jabref/pull/11843)
 - When fulltext search is selected but indexing is deactivated, a dialog is now shown asking if the user wants to enable indexing now [#9491](https://github.com/JabRef/jabref/issues/9491)
+- We changed instances of 'Search Selected' to 'Search Pre-configured' in Web Search Preferences UI. [#11871](https://github.com/JabRef/jabref/pull/11871)
 
 ### Fixed
 
diff --git a/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.fxml b/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.fxml
index 463debd9327..fc4fd940e07 100644
--- a/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.fxml
+++ b/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.fxml
@@ -27,7 +27,7 @@
         <CheckBox fx:id="useCustomDOI" text="%Use custom DOI base URI for article access"/>
         <TextField fx:id="useCustomDOIName" HBox.hgrow="ALWAYS"/>
     </HBox>
-    <Label styleClass="sectionHeader" text="%Catalogues used for 'Search Selected'"/>
+    <Label styleClass="sectionHeader" text="%Catalogues used for 'Search pre-configured'"/>
     <TableView
             fx:id="catalogTable"
             VBox.vgrow="ALWAYS"
diff --git a/src/main/java/org/jabref/logic/importer/WebFetchers.java b/src/main/java/org/jabref/logic/importer/WebFetchers.java
index 78479f67df4..de6c8b79545 100644
--- a/src/main/java/org/jabref/logic/importer/WebFetchers.java
+++ b/src/main/java/org/jabref/logic/importer/WebFetchers.java
@@ -238,7 +238,7 @@ public static Set<CustomizableKeyFetcher> getCustomizableKeyFetchers(ImportForma
 }
 
 /**
- *  Places "Search Selected" to the first of the set
+ *  Places "Search pre-configured" to the first of the set
  */
 class CompositeSearchFirstComparator implements Comparator<SearchBasedFetcher> {
     @Override
diff --git a/src/main/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcher.java b/src/main/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcher.java
index 5e23c8610c0..224900238b2 100644
--- a/src/main/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcher.java
+++ b/src/main/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcher.java
@@ -18,7 +18,7 @@
 
 public class CompositeSearchBasedFetcher implements SearchBasedFetcher {
 
-    public static final String FETCHER_NAME = "Search Selected";
+    public static final String FETCHER_NAME = "Search pre-configured";
 
     private static final Logger LOGGER = LoggerFactory.getLogger(CompositeSearchBasedFetcher.class);
 
diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties
index e7703f1bed7..454a38cf4a6 100644
--- a/src/main/resources/l10n/JabRef_en.properties
+++ b/src/main/resources/l10n/JabRef_en.properties
@@ -125,7 +125,7 @@ Case\ sensitive=Case sensitive
 
 change\ assignment\ of\ entries=change assignment of entries
 
-Catalogues\ used\ for\ 'Search\ Selected'=Catalogues used for 'Search Selected'
+Catalogues\ used\ for\ 'Search\ pre-configured'=Catalogues used for 'Search pre-configured'
 
 Change\ case=Change case