SLR: Rename "database" to "catalog"

[koppor]

"database" is a term used often in JabRef (shared database, ...). To name the systems providing data (which are fetched by our fetchers), we opted for "catalog".

In the SLR UI and in the SLR code, database has to be renamed to catalog.

[Siedlerchr]

UI and l10n to be adapted in ManageStudyDefintion.fxml

[nitesh-chowdhary]

I would like to work on it

[varad64]

Hello @koppor, @Siedlerchr. I'm new to the project. To clarify, inside the slr directory, all fields and their usages, containing database have to be renamed to catalog?

Thanks in advance.

[Siedlerchr]

@varad64 Yes, but of course only where it makes sense e.g. (bibdatabase and bibdatabasecontex NOT).
and especially in the UI and the localization has to be adjusted as well.

We are talking about this dialog (Tools -> Start new Systematic literature view)

[varad64]

Understood, thanks @Siedlerchr. I'll get started

[varad64]

Hello @Siedlerchr, I have renamed "database" to catalog. But when I run gradlew check, I am running into NPE caused by the now getCatalogs() method (renamed from getDatabases()) returning null which leads 7 tests to fail. I can't wrap my head around what might be causing these. Any pointers would be very helpful.

PFA screenshot of the failing tests and stacktrace for reference:

Thanks!

[Siedlerchr]

Try setting up a debugger and find out why the method getActiveLibraryEntries returns null.
And maybe you can also create a Draft PR already, that also makes it easier to spot any potential issues

[koppor]

This issue is worked on. Please do not take it.