Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable drag'n'drop of groups to new library #530

Closed
koppor opened this issue Nov 3, 2021 · 1 comment · Fixed by JabRef/jabref#9460
Closed

Enable drag'n'drop of groups to new library #530

koppor opened this issue Nov 3, 2021 · 1 comment · Fixed by JabRef/jabref#9460
Labels

Comments

@koppor
Copy link
Member

koppor commented Nov 3, 2021

grafik

@rafatd
Copy link

rafatd commented Dec 16, 2022

Mr Koppor,

I was attempting to work on this problem, which I eventually resolved. However, I ran into a minor issue. The problem is as follows: Whenever a library is created it does not get a root group at the same time, instead, a root group is only created for a library whenever "add group" button is used, which makes it quite complicated to drag'n'drop groups to it. I had to improvise by adding a root group into that library to be able to drop the dragged groups.

Please let me know if I should not do that? Or if there is another way to solve that issue.

Also on a side note: I know this was not asked but I thought it would be useful to also add the subgroups of the dragged groups. I think it makes more sense that was. Let me know if this solution is useful.

Please find bellow my PR link, let me know if you are happy with what I made.
JabRef#9460

Just to also confirm, I was not able to write tests for that, I do not think its possible, let me know if I am wrong.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants