Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TexGroup #498

Open
k3KAW8Pnf7mkmdSMPHz27 opened this issue Jun 7, 2021 · 0 comments
Open

Refactor TexGroup #498

k3KAW8Pnf7mkmdSMPHz27 opened this issue Jun 7, 2021 · 0 comments
Labels
code quality

Comments

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

After JabRef#7728 is merged, there will be at least three different methods resolving relative paths in the latexFileDirectory.

  1. https://github.com/JabRef/jabref/blob/bfe2679a5f3c1676dc47ab303a08726d2b4a6f12/src/main/java/org/jabref/model/groups/TexGroup.java#L139-L142
  2. https://github.com/JabRef/jabref/blob/bfe2679a5f3c1676dc47ab303a08726d2b4a6f12/src/main/java/org/jabref/gui/groups/GroupDialogViewModel.java#L437-L442
  3. https://github.com/aloofluo/jabref/blob/e7c8131996b956063eeba46a473566d83b9ed3ea/src/main/java/org/jabref/gui/groups/GroupDialogViewModel.java#L271-L273

There seems to be a need of removing most of the logic from TexGroup to prevent these kinds of issues from arising again.
At the same time perhaps its dependency on the logic layer can be completely removed.

https://github.com/JabRef/jabref/blob/bfe2679a5f3c1676dc47ab303a08726d2b4a6f12/src/main/java/org/jabref/model/groups/TexGroup.java#L12-L13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koppor @k3KAW8Pnf7mkmdSMPHz27