Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check architecture tests #352

Open
koppor opened this issue Oct 18, 2019 · 2 comments
Open

Check architecture tests #352

koppor opened this issue Oct 18, 2019 · 2 comments

Comments

@koppor
Copy link
Member

koppor commented Oct 18, 2019

Why can JavaFX be imported in the logic package without alarms going off?

Refs JabRef#5470

@matthiasgeiger
Copy link
Member

matthiasgeiger commented Oct 18, 2019

Therefore:
https://github.com/JabRef/jabref/blob/bc26c3ac5a3f3e0e7d806ac3639bf079c98441e0/src/test/java/org/jabref/architecture/MainArchitectureTests.java#L49

I don't remember where and when this was discussed but the outcome was that using the FXcollections should be allowed in logic.

Edit: Git blame FTW: JabRef#2719

@koppor
Copy link
Member Author

koppor commented Oct 18, 2019

Yeah, I remember the long discussions in the dev call. I was on the side to allow them 🙈. Should rethink it now that Eclipse Collections (JabRef#3023)
is mature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants