Add explicit support for length attribute #224
Closed
+104
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The length attribute works by happy accident today. This adds initial explicit support for it and also gets it work with filter conditions. This is not complete support. It won't (for instance) work correctly within array filter conditions. See the test changes for use cases it does add support for. Note that the ietf standardization for length() and count() functions is done differently. See: https://ietf-wg-jsonpath.github.io/draft-ietf-jsonpath-base/draft-ietf-jsonpath-base.html#name-length-function-extension Fixes JSONPath-Plus#202
gerad
commented
Oct 11, 2024
| const res0 = result[0]; | ||
| result = [{ | ||
| path: push(res0.path, 'length'), | ||
| value: result.length, |
| @@ -260,15 +260,31 @@ JSONPath.prototype.evaluate = function ( | |||
| if (exprList[0] === '$' && exprList.length > 1) { | |||
| exprList.shift(); | |||
| } | |||
| let wantsLength = false; | |||
| if (exprList.at(-1) === 'length') { | |||
There was a problem hiding this comment.
I think treating .length as length function is a bad idea, it will conflict with length property, if the object has it.
|
I think we really need to freeze development which does not align with the IETF spec (unless that spec is truly deficient in some way and in such a case, follow the jsonpath comparison project as possible for the way forward). |
|
Thanks for the fast feedback both! Good point on objects with a length property. Will revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The length attribute works by happy accident today. This adds initial explicit support for it and also gets it work with filter conditions.
This is not complete support. It won't (for instance) work correctly within array filter conditions. See the test changes for use cases it does add support for.
Note that the ietf standardization for length() and count() functions is done differently.
See: https://ietf-wg-jsonpath.github.io/draft-ietf-jsonpath-base/draft-ietf-jsonpath-base.html#name-length-function-extension
Fixes #202
Checklist
npm test, ensuring linting passes