Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect CRTM AMSU-A Spectral Coeff file on hera #1046

Closed
ADCollard opened this issue Mar 27, 2024 · 14 comments
Closed

Incorrect CRTM AMSU-A Spectral Coeff file on hera #1046

ADCollard opened this issue Mar 27, 2024 · 14 comments
Assignees
Labels
bug Something is not working NOAA-EMC OAR-EPIC NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center

Comments

@ADCollard
Copy link

This is a similar issue to that already addressed in Issue 963

The AMSU-A Metop-C spectral coefficient file needs special treatment as the one supplied with the default file name is not correct. The details on what to do are in that issue.

The correct file has the following cksum:

1237040622 12196 amsua_metop-c.SpcCoeff.bin

This one is from orion at /work/noaa/epic/role-epic/spack-stack/orion/spack-stack-1.6.0/envs/unified-env/install/intel/2022.0.2/crtm-fix-2.4.0.1_emc-ezbyzji/fix

On Hera at /scratch1/NCEPDEV/nems/role.epic/spack-stack/spack-stack-1.6.0/envs/unified-env-rocky8/install/intel/2021.5.0/crtm-fix-2.4.0.1_emc-bm46d3q/fix (which is the path given by $CRTM_FIX when the appropriate modules are loaded as specified in the develop version of GSI) the cksum is:

1692416252 1252 amsua_metop-c.SpcCoeff.bin

This causes a failure when trying to run the develop version of GSI.

@ADCollard ADCollard added the bug Something is not working label Mar 27, 2024
@ADCollard
Copy link
Author

@DavidHuber-NOAA Could you take a look at this if you have time?

@RussTreadon-NOAA
Copy link

Hercules check

Log into Hercules. Load GSI modulefiles/gsi_hercules.intel and cd $CRTM_FIX. The correct amsua_metop-c.SpcCoeff.bin is installed on Hercules

hercules-login-4:/work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/unified-env/install/intel/2021.9.0/crtm-fix-2.4.0.1_emc-2os2hw2/fix$ cksum amsua_metop-c.SpcCoeff.bin
1237040622 12196 amsua_metop-c.SpcCoeff.bin

Thank you @ADCollard for reporting this problem. This issue prompted me to check GSI regression tests. The global_4denvar test sets ta2tb=.false., This should be changed to ta2tb=.true. since this is how operations runs the global GSI.

@climbfuji climbfuji added NOAA-EMC OAR-EPIC NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center labels Apr 1, 2024
@DavidHuber-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA @climbfuji @ADCollard I verified this does need to be fixed. The procedure outlined in #963 should work fine again here. This also needs to be fixed on Jet Rocky 8 installations.

@climbfuji
Copy link
Collaborator

@RatkoVasic-NOAA Can you work with @DavidHuber-NOAA to fix this, please?

@DavidHuber-NOAA
Copy link
Collaborator

@RatkoVasic-NOAA Apologies for not bringing this up in the spack-stack meeting. Is this something that can be addressed?

@RatkoVasic-NOAA
Copy link
Collaborator

@DavidHuber-NOAA does this mean we just have to copy amsua_metop-c.SpcCoeff.bin to all our installations? If yes, which one we know is correct? And I can use that one to populate to all environments/versions.

@DavidHuber-NOAA
Copy link
Collaborator

@RatkoVasic-NOAA This only applies to spack-stack v1.6.0 Rocky 8 installations on Hera and Jet and only needs to be applied to the unified-env-rocky8 environment (the gsi-addon-rocky8 uses the unified-env-rocky8 installation of crtm-fix).

A good copy of the fix file can be found here:
/scratch1/NCEPDEV/nems/role.epic/spack-stack/spack-stack-1.5.1/envs/unified-env-rocky8/install/intel/2021.5.0/crtm-fix-2.4.0_emc-sh2qz24/fix/amsua_metop-c.SpcCoeff.bin

@RatkoVasic-NOAA
Copy link
Collaborator

@DavidHuber-NOAA thanks! I'm going to update it.

@RatkoVasic-NOAA
Copy link
Collaborator

@DavidHuber-NOAA BTW, I checked other files as well. Beside amsua_metop-c.SpcCoeff.bin, there are two more files that differ:
atms_j2.SpcCoeff.bin
atms_n21.SpcCoeff.bin
Do you know if that is expected?

@DavidHuber-NOAA
Copy link
Collaborator

@RatkoVasic-NOAA I'm not certain on this.
@ADCollard Do you know if these changes are expected between crtm-fix v2.4.0 and v2.4.0.1?

@ADCollard
Copy link
Author

@RatkoVasic-NOAA @DavidHuber-NOAA Thanks for doing this! This whole sorry saga started with atms_n21! Hopefully for 2.4.0.1 the cksums should be as follows:

andrew.collard@dlogin06:/apps/ops/para/libs/intel/19.1.3.304/crtm/2.4.0.1/fix> cksum atms_n21.SpcCoeff.bin
3709800805 1960 atms_n21.SpcCoeff.bin
andrew.collard@dlogin06:/apps/ops/para/libs/intel/19.1.3.304/crtm/2.4.0.1/fix> cksum atms_j2.SpcCoeff.bin
4188410122 1960 atms_j2.SpcCoeff.bin

@RatkoVasic-NOAA
Copy link
Collaborator

@ADCollard thanks, it is correct in spack-stack-1.6.0/crtm-fix-2.4.0.1

@DavidHuber-NOAA
Copy link
Collaborator

The checksums and sizes are both correct now:

1237040622 12196 /lfs4/HFIP/hfv3gfs/role.epic/spack-stack/spack-stack-1.6.0/envs/unified-env-rocky8/install/intel/2021.5.0/crtm-fix-2.4.0.1_emc-z2uz6da/fix/amsua_metop-c.SpcCoeff.bin

1237040622 12196 /scratch1/NCEPDEV/nems/role.epic/spack-stack/spack-stack-1.6.0/envs/unified-env-rocky8/install/intel/2021.5.0/crtm-fix-2.4.0.1_emc-bm46d3q/fix/amsua_metop-c.SpcCoeff.bin

I think this can now be closed. Thanks @RatkoVasic-NOAA!

@climbfuji
Copy link
Collaborator

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working NOAA-EMC OAR-EPIC NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center
Projects
No open projects
Development

No branches or pull requests

6 participants