Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring that surface: reflectivity, direct_reflectivity, and emissivity are bounded from [0:1], inclusive. #123

Merged

Conversation

BenjaminTJohnson
Copy link
Contributor

@BenjaminTJohnson BenjaminTJohnson commented Apr 1, 2024

Description

In issue #119, we had occasional negative values of radiance, that were resulting from negative emissivity values for VIS/near-IR channels. CRTM attempts to compute emissivity for all channels, regardless of whether they'd produce any thermal radiance or not. This PR is fairly heavy-handed in bounding surface emissivities and reflectivities to be between 0 and 1. The risk is that this could potentially mask other emissivity problems.

Please test for VIS/near IR channels in particular, GOES ABI channels 5-7.

If emissivity/reflectivity/direct_reflectivity tries to be less than 0 or greater than 1, it is set to either 0 or 1, respectively.

Issue(s) addressed

Resolves #119

Impact

None expected.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

…efined emissivity. see test/mains/unit/Unit_Test/Test_Options.f90
…efined emissivity. see test/mains/unit/Unit_Test/Test_Options.f90
@BenjaminTJohnson BenjaminTJohnson self-assigned this Apr 2, 2024
Copy link
Contributor

@chengdang chengdang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approve as I have not run the ctests yet.
The code changes look good to me. I'm only a bit worried about the amount of warning messages in the log files for JEDI simulation, but that's something we can work on later perhaps.

@chengdang
Copy link
Contributor

Updates: all standalone CRTM ctests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

computed emissivities greater than 1 occasionally cause FPEs in VIS/nearIR calculations
2 participants