TODO: Ability to ignore blank line changes

[DigiLive]

Can you elaborate on the ability to ignore blank line changes?

[JBlond]

That is a good idea. I did spent any time on that yet.

[JBlond]

I guess it should no be too hard to implement in function linesAreDifferent. White space ignore is already there.
Maybe a

<?php
preg_replace('/(^[\r\n]*|[\r\n]+)[\s\t]*[\r\n]+/', '$1', $input);

or better use

/(?m)(.*)(\R?\n\1)+$/

[DigiLive]

I don't know... I actually wanted you to clarify what the todo item means. 😅

[JBlond]

it means, that in a comparison blank lines should be ignored (as an option).

It is in the readme file before I forked the repo.

[DigiLive]

I'm sorry, but I still don't follow 😅...
If a line is blank at both versions, they're just the same and unmarked.
(Version1, line 15 vs Version2, line 14)
If a line is blank at only 1 version, it shouldn't be ignored because the line at the other version isn't blank.
(Version1, line 8 and Version2, line 14)

Please provide an example so I can clearly understand what it means.

[JBlond]

Don't compare blank lines at all and or example

file a) blank lines 10 - 12. file b) blank lines 10 - 27. With the option set there is no difference.

For example when I compare CSV files I don't care about some blank lines. The content it what counts. Blank lines are ignored at import into any system.

[DigiLive]

Nope. Sorry, I just don't get it.
You can email me an excel file which mimics the output of the SideBySide renderer with such option enabled.

[JBlond]

I created a gist. https://gist.github.com/JBlond/1632bc8b134a3dbb9545bbbdbcfe7021
With the option set the diff should show no differences.

[DigiLive]

Do you prefer to introduce a new tag, e.g. ignored or do you really want to tag the ignored 'differences' as being equal?

[JBlond]

Choose as you like. Add a new tag is fine. It might be more clear.

[DigiLive]

I think I'm getting somewhere.
Will make a PR soon to be thoroughly tested.

[DigiLive]

Please test PR #86

[JBlond]

I'll get to that after Christmas.