Fix HTML Merged Renderer

Stray </tbody> tags present when lines removed from version 2.
JBlond · Nov 21, 2020 · 07da484 · 07da484
1 parent cf516d1
commit 07da484
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/jblond/Diff/Renderer/Html/Merged.php b/lib/jblond/Diff/Renderer/Html/Merged.php
@@ -253,7 +253,7 @@ function ($removedParts) use ($addedParts) {
      */
     public function generateBlockFooter(array $changes): string
     {
-        return '</tbody>';
+        return $changes['tag'] != 'delete' ? '</tbody>' : '';
     }
 
     /**

diff --git a/tests/resources/htmlMerged.txt b/tests/resources/htmlMerged.txt
@@ -24,7 +24,7 @@
 </tr><tr>
     <th class="" title="">7</th>
     <td>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&lt;h1&gt;This is demo content to show features of the php-diff package.&lt;/h1&gt;</td>
-</tr></tbody></tbody><tbody class="ChangeEqual"><tr>
+</tr></tbody><tbody class="ChangeEqual"><tr>
     <th class="ChangeDelete" title="Lines deleted at Version2:
 8: &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&lt;h2&gt;This line is removed from version2.&lt;/h2&gt;
 ">8</th>
-Original file line number
+Diff line change
@@ Expand Up / @@ -253,7 +253,7 @@ function ($removedParts) use ($addedParts) { @@
          */
         public function generateBlockFooter(array $changes): string
         {
-            return '</tbody>';
+            return $changes['tag'] != 'delete' ? '</tbody>' : '';
         }
         /**
@@ Expand Down @@