Duplicate points of interests when zooming

[nadavheimann]

i have multipal interest point on same point
look at the attachment

its same problem at all points

[HarelM]

I have seen this happen from time to time, I could not understand when and why it starts.
This seems to pass when refreshing the browser.
This seems to get worse when zooming and panning the map.
Let me know if you can find a short scenario that reproduces this behavior, I couldn't... :-(

[HarelM]

I was able to reproduce the issue using a scenario similar to this one:
Change base layer may time while changing with the visibility of the categories inside the public routes layer. after playing with both buttons for a while I get the following error message, from then on, every change in zoom level adds some markers to the cluster:

ERROR Error: Uncaught (in promise): TypeError: Cannot read property '_zoom' of undefined
TypeError: Cannot read property '_zoom' of undefined
    at NewClass._addLayer (leaflet.markercluster.js:6)
    at NewClass.addLayer (leaflet.markercluster.js:6)
    at categories.layer.ts:135
    at ZoneDelegate.webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invoke (zone.js:392)
    at Object.onInvoke (core.js:4629)
    at ZoneDelegate.webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invoke (zone.js:391)
    at Zone.webpackJsonp.../../../../zone.js/dist/zone.js.Zone.run (zone.js:142)
    at zone.js:873
    at ZoneDelegate.webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:425)
    at Object.onInvokeTask (core.js:4620)
    at NewClass._addLayer (leaflet.markercluster.js:6)
    at NewClass.addLayer (leaflet.markercluster.js:6)
    at categories.layer.ts:135
    at ZoneDelegate.webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invoke (zone.js:392)
    at Object.onInvoke (core.js:4629)
    at ZoneDelegate.webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invoke (zone.js:391)
    at Zone.webpackJsonp.../../../../zone.js/dist/zone.js.Zone.run (zone.js:142)
    at zone.js:873
    at ZoneDelegate.webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:425)
    at Object.onInvokeTask (core.js:4620)
    at resolvePromise (zone.js:824)
    at zone.js:876
    at ZoneDelegate.webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:425)
    at Object.onInvokeTask (core.js:4620)
    at ZoneDelegate.webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:424)
    at Zone.webpackJsonp.../../../../zone.js/dist/zone.js.Zone.runTask (zone.js:192)
    at drainMicroTaskQueue (zone.js:602)
    at ZoneTask.webpackJsonp.../../../../zone.js/dist/zone.js.ZoneTask.invokeTask [as invoke] (zone.js:503)
    at invokeTask (zone.js:1540)
    at XMLHttpRequest.globalZoneAwareCallback (zone.js:1566)

@MatanBenMoshe, FYI.

[HarelM]

Related check-in is to reverse the order of changing a base-layer - first we add the new layer and then remove the previous, I think this might explain this issue as the cluster layer doesn't work well when there's no base layer, I think...

[HarelM]

I'm publishing a fix tonight for this issue, I was somewhat able to reproduce it, although I'm not sure this is the only scenario which causes the bug.
I don't have a good reproducible scenario as it is related to timing, but after the code change I was not able to reproduce it again so I'm hoping I found the root cause...
In case if you see this happening again after tonight upgrade please write here and I'll reopen the issue.

[HarelM]

The issue was not solved using the code changes I made.
I can now easily reproduce it using the following scenario:
Go to:
https://israelhiking.osm.org.il/#!/13/32.9843/35.4004

1. hide all route layers
2. show only bike routes
3. hide bike routes
4. show bike routes --> bug can be seen in console and when zooming.
   Discussed also in Duplicate markers Leaflet/Leaflet.markercluster#860

[HarelM]

@nadavheimann @MatanBenMoshe I'll publish tonight a fix to this issue, hopefully will put this issue behind us once and for all.
If you encounter this issue again please report it here and I'll reopen this issue.

[HarelM]

Published.

[nadavheimann]

Thanks, I will check later

…

On Mar 1, 2018 09:24, "Harel M" ***@***.***> wrote: Published. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#582 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEu4hi2UjdRWhgCDnF_9mbbRSDQD6Je-ks5tZ6JEgaJpZM4ROQgE> .

[amiad]

The problem happen again.

[HarelM]

I need to be able to reproduce the scenario in order to do something with your report...
Can you see if you can find a way to make it happen?

[amiad]

I hide and show some times the route layers and then when I move the map or zoom it the points duplicate.

[HarelM]

Yes, this is how I originally discovered this issue, but after the fix I made I didn't saw it happen again.
I don't have a good way to reproduce it so it will be extremely hard for me to fix it.
If you find a scenario that is easy to reproduce please share it and I'll see if I can help.