Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework NUID #26

Closed
Ismoh opened this issue Feb 24, 2022 · 1 comment
Closed

Rework NUID #26

Ismoh opened this issue Feb 24, 2022 · 1 comment
Assignees
@Ismoh
Labels
bug Something isn't working. This will increase PATCH version number, when merged into develop. enhancement New feature or request. This will increase MINOR version number, when merged into develop.

Comments

@Ismoh
Copy link
Owner

Ismoh commented Feb 24, 2022

There is an unique network identifier used to have persistent entities.

Atm each entity has a variableStorageComponent, which holds a serialised lua table. This leads to problems when deserialising for some reason.

Better way is:
Clients despawn their entities and server send their entities to all clients. Each entity will have one variable storage component per attribute of network component, without serialising this network component. Therefore the entity will have persistent data after saving and restarting Noita.
@Ismoh Ismoh added bug Something isn't working. This will increase PATCH version number, when merged into develop. enhancement New feature or request. This will increase MINOR version number, when merged into develop. labels Feb 24, 2022
@Ismoh Ismoh self-assigned this Feb 24, 2022
@Ismoh
Copy link
Owner Author

Ismoh commented Mar 11, 2022

Whoopsi. Have a look on #27 :D

@Ismoh Ismoh closed this as completed Mar 11, 2022
@Ismoh Ismoh mentioned this issue Mar 11, 2022
Closed
This was referenced Sep 27, 2022
Merged
Merged
This was referenced Oct 6, 2022
Merged
Merged
@github-actions github-actions bot mentioned this issue Oct 14, 2022
Merged
This was referenced Oct 27, 2022
Closed
Merged
Merged
@Ismoh Ismoh added this to NoitaMP Nov 22, 2022
@Ismoh Ismoh moved this to ✅ Done in NoitaMP Nov 22, 2022
This was referenced Jan 9, 2023
Merged
Merged
@github-actions github-actions bot mentioned this issue Jan 16, 2023
Closed
@github-actions github-actions bot mentioned this issue Feb 17, 2023
Merged
@github-actions github-actions bot mentioned this issue Mar 5, 2023
Merged
This was referenced Jun 30, 2023
Closed
Closed
Closed
Closed
Closed
Merged
Merged
@github-actions github-actions bot mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ismoh Ismoh

Labels
bug Something isn't working. This will increase PATCH version number, when merged into develop. enhancement New feature or request. This will increase MINOR version number, when merged into develop.
Projects
NoitaMP
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ismoh