Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer want to sync children and components #107

Closed
Ismoh opened this issue Jan 17, 2023 · 2 comments
Closed

Developer want to sync children and components #107

Ismoh opened this issue Jan 17, 2023 · 2 comments
Assignees
@Ismoh
Labels
enhancement New feature or request. This will increase MINOR version number, when merged into develop.
Milestone
Synchronisation

Comments

@Ismoh
Copy link
Owner

Ismoh commented Jan 17, 2023

Currently childrens aren't synced correctly.
Put this for in a local function and do recursive call, until there aren't any children anymore.

Also add component syncing.
Add a list, which components should be synced.
VariableStorageComponents should be enough for now.
@Ismoh Ismoh added the enhancement New feature or request. This will increase MINOR version number, when merged into develop. label Jan 17, 2023
@Ismoh Ismoh added this to the Synchronisation milestone Jan 17, 2023
@Ismoh Ismoh self-assigned this Jan 17, 2023
@Ismoh Ismoh added this to NoitaMP Jan 17, 2023
@Ismoh Ismoh moved this to 📋 Backlog in NoitaMP Jan 17, 2023
@Ismoh Ismoh moved this from 📋 Backlog to 🔖 Ready in NoitaMP Jan 17, 2023
@Ismoh
Copy link
Owner Author

Ismoh commented Feb 15, 2023 •
edited
Loading

image
image
image

@Ismoh
Copy link
Owner Author

Ismoh commented Feb 20, 2023

Will be done in #67

@Ismoh Ismoh closed this as completed Feb 20, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in NoitaMP Feb 20, 2023
@github-actions github-actions bot mentioned this issue Mar 5, 2023
Merged
@Ismoh Ismoh reopened this Mar 5, 2023
@Ismoh Ismoh closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2023
This was referenced Jun 30, 2023
Closed
Closed
Closed
Closed
Closed
Merged
Merged
@github-actions github-actions bot mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ismoh Ismoh

Labels
enhancement New feature or request. This will increase MINOR version number, when merged into develop.
Projects
NoitaMP
Status: ✅ Done
Milestone
Synchronisation
Development

No branches or pull requests
1 participant
@Ismoh