Avoid attempting to refer to an unknown index in views alter hook #876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in a bare site (without any content... like, in a unit
testing rig), this ends up trying to refer to a non-existent offset.
... add an
isset()
test to avoid doing so.GitHub Issue: This one.
Release pull requests, etc.)
N/A
What does this Pull Request do?
Tests of the existence of views data being copied before attempting to reference it, as it may not exist.
What's new?
Just added an
isset()
check before blindly attempting to use views data.(i.e. Regeneration activity, etc.)? No.
How should this be tested?
Good question... kind of surprised this doesn't pop up in this module's tests...
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers