Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/previews #2234

Merged
merged 6 commits into from
May 31, 2023
Merged

Feature/previews #2234

merged 6 commits into from
May 31, 2023

Conversation

adam-vessey
Copy link
Contributor

@adam-vessey adam-vessey commented May 24, 2023

Purpose / why

Allows for previewing of the built site, may serve as something of a test for other changes.

What changes were made?

Changed out the docs were deployed, and added the preview action.

Verification

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@github-actions
Copy link

PR Preview Action v1.4.4
🚀 Deployed preview to https://Islandora.github.io/documentation/pr-preview/pr-2234/
on branch gh-pages at 2023-05-24 20:00 UTC

@adam-vessey adam-vessey marked this pull request as ready for review May 24, 2023 20:02
@whikloj
Copy link
Member

whikloj commented May 24, 2023

Very cool 👏

@rosiel rosiel merged commit 804eda8 into main May 31, 2023
@rosiel rosiel deleted the feature/previews branch May 31, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants