Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup PR template on all Islandora CLAW GitHub organization repositories #541

Closed
30 tasks done
ruebot opened this issue Feb 23, 2017 · 9 comments
Closed
30 tasks done
Assignees

Comments

@ruebot
Copy link
Member

ruebot commented Feb 23, 2017

Let's start with the current template in 1.x, and update it where we need to. I'll put this on the agenda for the next CLAW call, to talk out any issues any of us have with the current template.

https://github.com/Islandora/islandora/blob/7.x/.github/PULL_REQUEST_TEMPLATE.md

  • CLAW
  • islandora
  • islandora_image
  • Alpaca
  • islandora_collection
  • claw-jsonld
  • claw_vagrant
  • drupal-project
  • claw-docker-fedora
  • Crayfish
  • claw-docker-open-jdk
  • claw-ansible
  • claw-docker
  • claw-docker-karaf
  • claw-docker-blazegraph
  • claw-docker-islandora-karaf-components
  • claw-docker-islandora
  • claw-docker-tomcat
  • claw-docker-maven
  • claw-docker-mariadb
  • claw-docker-all-in-one
  • claw-docker-solr
  • claw-docker-oracle-jdk
  • claw-docker-base
  • claw-docker-drupal
  • Salmon
  • chullo
  • pdx
  • claw_install_profile
  • claw-service-scripts
@ruebot ruebot added the newbie label Feb 23, 2017
@ruebot
Copy link
Member Author

ruebot commented Mar 1, 2017

GitHub Issue: (link)

  • Other Relevant Links (Google Groups discussion, related pull requests, Release pull requests, etc.)

What does this Pull Request do?

A brief description of what the intended result of the PR will be and/or what problem it solves.

What's new?

A in-depth description of the changes made by this PR. Technical details and possible side effects.

  • Changes x feature to such that y
  • Added x
  • Removed y
  • Does this change require documentation to be updated?
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)?
  • Could this change impact execution of existing code?

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the Pull Request does what is intended.
  • Please be as detailed as possible.
  • Good testing instructions help get your PR completed faster.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-CLAW/committers

@ruebot
Copy link
Member Author

ruebot commented Mar 1, 2017

**GitHub Issue**: (link)

* Other Relevant Links (Google Groups discussion, related pull requests, Release pull requests, etc.)

# What does this Pull Request do?

A brief description of what the intended result of the PR will be and/or what problem it solves.

# What's new?
A in-depth description of the changes made by this PR. Technical details and possible side effects.

* Changes x feature to such that y
* Added x
* Removed y
* Does this change require documentation to be updated? 
* Does this change add any new dependencies? 
* Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? 
* Could this change impact execution of existing code?

# How should this be tested?

A description of what steps someone could take to:
* Reproduce the problem you are fixing (if applicable)
* Test that the Pull Request does what is intended.
* Please be as detailed as possible.
* Good testing instructions help get your PR completed faster.

# Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.

# Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora-CLAW/committers

@whikloj whikloj closed this as completed Mar 1, 2017
@whikloj
Copy link
Member

whikloj commented Mar 1, 2017

Ooops

@whikloj whikloj reopened this Mar 1, 2017
@whikloj
Copy link
Member

whikloj commented Mar 1, 2017

Do we need to update all these repos? Some of this code is of questionable value moving forward. I mean, it won't hurt anything. Just thinking about the chullo/PDX/Crayfish world.

@ruebot
Copy link
Member Author

ruebot commented Mar 1, 2017

@whikloj might as well just so we're consistent. We still need to have the conversation about what to do with the stuff we don't use anymore. Maybe just move it all to Islandora Deprecated, and if we need to bring it back over, bring it back over?

@ruebot
Copy link
Member Author

ruebot commented Mar 2, 2017

Done. Thanks so much @Amandarl!!

@dannylamb
Copy link
Contributor

@ruebot Are we good to close this?

@ruebot
Copy link
Member Author

ruebot commented Mar 6, 2017

Oh, I totally thought I closed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants