Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configuration to determine what services to expose publicly #1667

Open
7 tasks
dannylamb opened this issue Oct 30, 2020 · 2 comments
Open
7 tasks

Use configuration to determine what services to expose publicly #1667

dannylamb opened this issue Oct 30, 2020 · 2 comments
Assignees
Labels
Subject: Docker ISLE Related to the maintenance and upkeep associated with ISLE’s docker image.

Comments

@dannylamb
Copy link
Contributor

ISLE lets users choose what services to deploy with variables in the .env, but whether or not they're exposed publicly isn't configurable. If we take our current docker-compose.*.yml files, we can set these up to run off of config using the traefik.enable label.

For example, in docker-compose.activemq.yml, we could do

      - traefik.enable="${EXPOSE_ACTIVEMQ}"

and then we could set $EXPOSE_ACTIVEMQ=true to enable or $EXPOSE_ACTIVEMQ=false to disable the route using the .env file.

We'd need to do this for:

@dannylamb dannylamb added the ISLE label Oct 30, 2020
@g7morris g7morris self-assigned this Oct 30, 2020
@noahwsmith
Copy link

Both #1665 and #1666 should be done first.

@kstapelfeldt kstapelfeldt added Subject: Docker ISLE Related to the maintenance and upkeep associated with ISLE’s docker image. and removed ISLE labels Sep 25, 2021
@joshdentremont
Copy link
Contributor

I see a lot of the yml files have comments that say do not expose in production. As part of this change would it be worth changing the defaults to false, so that they need to be manually exposed in the .env? That way we could also include these comments in the .env and if someone wants to turn them on they have been warned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subject: Docker ISLE Related to the maintenance and upkeep associated with ISLE’s docker image.
Projects
Development

No branches or pull requests

5 participants