Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDTF Formatter Year configuration fix (Issue 2016) #76

Merged
merged 4 commits into from
Jan 26, 2022
Merged

EDTF Formatter Year configuration fix (Issue 2016) #76

merged 4 commits into from
Jan 26, 2022

Conversation

seth-shaw-unlv
Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv commented Dec 21, 2021

GitHub Issue: Islandora/documentation#2016

What does this Pull Request do?

Allows persisting the year configuration for the EDTF formatter. Makes the middle-endian special condition case more stringent.

What's new?

  • Added default year_format.
  • Fixed the copy/pasta the two-digit year option text.
  • Added the mysql fix that has been killing builds lately.
  • Makes the middle-endian case require day and year as well as the space separator.

How should this be tested?

  1. created a record with today's date using the date created field from islandora_defaults:

Screen Shot 2021-12-21 at 11 49 51 AM

  1. In the default islandora object display mode, the date created display settings inexplicitly says "Do not show year" even though it did:

Screen Shot 2021-12-21 at 11 50 54 AM

  1. Also notice the two-digit year option copied the option text from month:

Screen Shot 2021-12-21 at 11 52 05 AM

  1. Select the middle-endian option and select the option to not display the year, save the changes, and view the record noticing that the year still displays:

Screen Shot 2021-12-21 at 11 53 57 AM

Screen Shot 2021-12-21 at 11 54 30 AM

  1. Apply the PR
  2. Clear cache
  3. Change the year settings to whatever you want and see their formatting correctly applied to your record.

Additional Notes:

I haven't fixed the middle-endian issue yet, but I wanted to get this up in case I'm pulled away before leaving on vacation.

Interested parties

@Islandora/8-x-committers

Fix for special case where middle-endian date order with spelled-out month and space separator should include a comma to separate the day and year.
@kstapelfeldt kstapelfeldt requested a review from Natkeeran January 5, 2022 18:24
@Natkeeran Natkeeran merged commit 6854095 into Islandora:2.x Jan 26, 2022
@seth-shaw-unlv seth-shaw-unlv deleted the issue-2016 branch January 26, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants