-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed adaptive theme to maintained fork. #24
Changed adaptive theme to maintained fork. #24
Conversation
292a06c
to
39579d4
Compare
Doesn't look like Travis builds are maintained, can we just turn that off to get this in? |
Travis is still being used for some repos, but in general i think we're shifting towards github actions. |
Well for those whom already have sites using carapace this is an easy change that allows them to update to Drupal 9. Certainly does no harm. Supporting carapace or not going forward this will save existing users time and hassle until they can transition to the new theme when done. |
gotcha, makes sense to me |
i think the composer install is failing so its missing phpcpd https://travis-ci.com/github/Islandora/carapace/jobs/496507435#L637 |
@nigelgbanks i rolled this change into #25 |
@elizoller awesome, I'll close this. |
* fix for phpcd in travis * still futzing with travis * still futzing with travis * still futzing with travis * trying phpunit update in islandora_ci * first attempt at github workflows * dear github actions, please work * attempt to get composer to install * attempt to get composer to install * taking the work from PR #24 to see if it'll allow d9 to work * removing phpunit since we don't have that for carapace * use custom phpcs targeting for carapace files specifically * fix filename * separating tests so i can see which one is failing * add .theme file for phpcpd * i don't have any files for phpcpd? * please run phpcpd * cd into the directory? * is it name not suffix for phpcpd * phpcpd still hates me * debugging whats going on with phpcpd * debugging whats going on with phpcpd * cleanup * phpcpd still hates me * remove verbosity * just run the theme file? * phpcpd anyone? * still working on phpcpd * trying more * special travis scripts file in ci * TODO for phpcpd and remove travis * remove unused file
Use new fork of adaptive theme, allows carapace to be used with Drupal 9.
@Islandora/8-x-committers