Change to symfony/flex

[whikloj]

GitHub Issue: Islandora/documentation#1224

What does this Pull Request do?

Crayfish can't change until ALL the microservices are switched to Symfony 4, so this will remain as an alternate branch and once the last microservice is switched we can merge this and then update the composer.json and composer.lock for all the microservices.

Changes the Crayfish-Commons library into a Symfony Bundle

• YamlServiceProvider is removed, symfony handles configuration differently.
• IslandoraServiceProvider is removed, this work is done in CrayfishCommonsExtension
• ApixMiddleware becomes an EventSubscriber
• Added a UserProvider for the JWTs

What's new?

The ApixMiddleware is currently always registered and acts on any request that is not a HEAD or OPTIONS request.

This could be a problem in future, we might want to add a config variable to allow services that don't use the Apix-Ldp-Resource header to disable this.

• Does this change require documentation to be updated? no
• Does this change add any new dependencies? updated dependencies
• Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
• Could this change impact execution of existing code? no

How should this be tested?

PRs coming to Crayfish, ansible-role-crayfish and claw-playbook

Interested parties

@Islandora-CLAW/committers

[codecov]

Codecov Report

Merging #28 (bcc0072) into dev (988ad57) will decrease coverage by 9.78%.
The diff coverage is 51.13%.

@@             Coverage Diff              @@
##                dev      #28      +/-   ##
============================================
- Coverage     92.53%   82.75%   -9.79%     
+ Complexity      136      127       -9     
============================================
  Files             9       10       +1     
  Lines           415      400      -15     
============================================
- Hits            384      331      -53     
- Misses           31       69      +38     

Impacted Files	Coverage Δ	Complexity Δ
Client/GeminiClient.php	98.55% <ø> (ø)	15.00 <0.00> (?)
DependencyInjection/Configuration.php	0.00% <0.00%> (ø)	1.00 <1.00> (?)
DependencyInjection/CrayfishCommonsExtension.php	0.00% <0.00%> (ø)	4.00 <4.00> (?)
Syn/JwtFactory.php	0.00% <ø> (ø)	1.00 <0.00> (?)
Syn/JwtUser.php	53.84% <ø> (ø)	6.00 <0.00> (?)
Syn/JwtUserProvider.php	0.00% <0.00%> (ø)	3.00 <3.00> (?)
Syn/SettingsParser.php	92.03% <ø> (ø)	47.00 <0.00> (?)
CmdExecuteService.php	84.09% <66.66%> (ø)	14.00 <1.00> (?)
ApixMiddleware.php	87.17% <71.42%> (ø)	9.00 <6.00> (?)
Syn/JwtAuthenticator.php	95.29% <91.66%> (ø)	27.00 <3.00> (?)
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 988ad57...9e0ec7f. Read the comment docs.

[whikloj]

Closing in favour of #49

[whikloj]

Leaving the symfony-flex branch in place for now until the PRs related to #49 are merged.