Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Service File" to the rows with tracks. #7

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

alxp
Copy link
Contributor

@alxp alxp commented Feb 5, 2024

Workbench's --check feature balks if you try to load a media track (transcript) on anything except a Service File. This PR adds "Service File" to the media use column (keeping Original File; thus double-tagging) on the six rows that have media tracks.

To test:

  • Does the spreadsheet pass --check on workbench?
  • When you visit those six objects, does the transcript show up as well as the video/audio?
  • If you check the media listings for those objects, you should see one tagged as BOTH Original and Service file. There should not be an additional Service File created by derivatives.

@rosiel
Copy link
Contributor

rosiel commented Feb 7, 2024

do not merge until mjordan/islandora_workbench#742 is merged.

Copy link
Contributor

@ajstanley ajstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with updated Workbench.

All nodes were successfully ingested.
All media successfully ingested and tagged.

@ajstanley ajstanley merged commit 1d244a2 into Islandora-Devops:main Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants