Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Config Override Warn? #112

Closed
nigelgbanks opened this issue Oct 6, 2023 · 3 comments
Closed

Install Config Override Warn? #112

nigelgbanks opened this issue Oct 6, 2023 · 3 comments
Assignees

Comments

@nigelgbanks
Copy link
Contributor

See the conversation here for more info.

Islandora-Devops/isle-site-template#12

@adam-vessey
Copy link
Collaborator

Another potential candiate: Config Override Inspector

I know config_override_warn in particular indicates:

This is not intended to be used on production environments.

From bit of looking, COI may require some additional hook implementations, if we have some odd forms setup for config entities, to help it target the appropriate fields; though, with this targeting, it can actually go and disable the relevant fields/elements, to prevent users from trying to change the values.

@rosiel
Copy link
Contributor

rosiel commented Oct 23, 2023

The UI from COI is much nicer.

Here's what Config Override Warn looks like: Fields aren't disabled, and you have to mentally translate the field's machine name into the field in the form.

Screenshot 2023-10-23 at 12 55 18 PM

Using COI, (after adding the important info to islandora.settings):

Screenshot 2023-10-23 at 1 00 01 PM

I'm leaning to COI, so will make a set of PRs that enable COI on all the currently overridden values.

@rosiel
Copy link
Contributor

rosiel commented Oct 24, 2023

PRs created for Islandora and IIIF, and for Openseadragon.

The rest of our overrides are for matomo and search_api, which are not COI compatible.

We could create a form alter for these, but where would it be good to put it? Will a form override cause complaints if the form is not found? (My guess is no but just want to make sure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants