This repository has been archived by the owner on Oct 10, 2021. It is now read-only.
Made fits address overrideable #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
A tiny change in config that will allow users to override the web address for the FITS microservice
What's new?
Switched out one hardcoded value for a variable.
How should this be tested?
Spinning up a new box should create a ca.islandora.alpaca.connector.fits file under /opt/karaf/deploy
The derivative.service.url should be http://localhost:8000/crayfits, unless you changed alpaca_fits_base_url in your startup config.
Interested parties
@Islandora-Devops/committers