More code reaping #61
Conversation
* Remove the remainder of transactions * Follow-up to Islandora#60 * Also addresses Islandora/documentation#581
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
===========================================
+ Coverage 82.48% 93.45% +10.97%
===========================================
Files 3 3
Lines 137 107 -30
===========================================
- Hits 113 100 -13
+ Misses 24 7 -17
Continue to review full report at Codecov.
|
|
@dannylamb here is a follow-up on #60. I found a bunch more that should be removed when I took a closer look. |
|
Awesome. I was stomping around in here while working on Islandora/Crayfish-Commons#1 and noticed it too. Deemed it out of scope for what I was working on and you beat me to the punch for a separate pull! I'll check it out soon. |
| return $this->client->request( | ||
| 'DELETE', | ||
| $uri, | ||
| $options | ||
| ); | ||
| } | ||
|
|
||
| protected function prepareUri($uri, $transaction = "") |
There was a problem hiding this comment.
Very happy to get rid of that bit of ugly.
There was a problem hiding this comment.
YUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUP!
|
Looks good. Tests run. Merging. |
|
|
Follow-up to #60