Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at #285; Update vagrant to use Drupal 8, and remove all Dr… #286

Merged
merged 3 commits into from
Jun 20, 2016
Merged

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Jun 14, 2016

…upal 7 CRUFT.

See: #285

@whikloj, @DiegoPino want to take a look at this? First pass at yanking out Drupal 7, and dropping in Drupal 8.

@whikloj
Copy link
Member

whikloj commented Jun 17, 2016

Running vagrant up

@whikloj
Copy link
Member

whikloj commented Jun 17, 2016

Came up fine, there are 3 minor issues on the Status report we could deal with.

  1. Search API

    The default Drupal Search module is still enabled. If you are using Search API, you probably want to uninstall the Search module for performance reasons.

    I'm very new to Drupal 8, but it seems like Search API is for making search interfaces and Search is just a generic ready-made search. I'm guessing that long-term we are going to want Search API. Thoughts?

  2. Trusted Host Settings

    The trusted_host_patterns setting is not configured in settings.php. This can lead to security vulnerabilities. It is highly recommended that you configure this. See Protecting against HTTP HOST Header attacks for more information.

    No brainer, looks like for vagrant we should add the block

    $settings['trusted_host_patterns'] = array(
    '^localhost$',
    );
    

    to the sites/default/settings.php file.

  3. Twig C extension

    Enabling the Twig C extension can greatly increase rendering performance. See the installation instructions for more detail.

    Again, we love improved performance. Looks like we install Twig with composer and build the C extensions into PHP.

@ruebot
Copy link
Member Author

ruebot commented Jun 19, 2016

@whikloj updated!

@whikloj whikloj merged commit fe5136c into Islandora:master Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants