Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Empty ITAD notes list causes API request error #2033

Closed
Spurlos opened this issue Aug 30, 2024 · 0 comments · Fixed by #2034
Closed

[BUG] Empty ITAD notes list causes API request error #2033

Spurlos opened this issue Aug 30, 2024 · 0 comments · Fixed by #2034
Labels
bug Something isn't working

Comments

@Spurlos
Copy link

Spurlos commented Aug 30, 2024

Expected Behavior

When I do not have any notes in ITAD, extension should not try to fetch data from API using empty gids list.

Actual Behavior

Extension is getting {"status_code":400,"reason_phrase":"Request body must be non-empty JSON array"} from https://api.isthereanydeal.com/lookup/shop/61/id/v1 endpoint by sending empty gids list derived from empty keys of notes list that were retrived from ITAD API over at https://api.isthereanydeal.com/user/notes/v1

My debug journey in screens below:

image
image
image
image
image
image
image
image

Steps to Reproduce the Problem

  1. Enable notes sync in extension options
  2. Ensure that you have no notes set in your ITAD account
  3. Load any page on Steam

Specifications

  • Augmented Steam Version: 4.1.0
  • Browser Version: Version 129.0.6668.12 (Official Build) beta (64-bit)
@Spurlos Spurlos added the bug Something isn't working label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant