Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure browser/OS dark mode works #47

Open
Inwerpsel opened this issue Oct 27, 2023 · 0 comments
Open

Ensure browser/OS dark mode works #47

Inwerpsel opened this issue Oct 27, 2023 · 0 comments
Labels
bug Something isn't working css-feature Adds support for some part of the CSS Spec enhancement New feature or request needs design Missing design ideas for crucial components needs info The issue probably doesn't have enough information/ideas to be actionable at this time

Comments

@Inwerpsel
Copy link
Owner

Inwerpsel commented Oct 27, 2023 •
edited
Loading

The app was created with a light mode browser setting, and to keep things simple I just ignored dark mode.

If you open the demo with a dark mode setting, you're possibly going to have a bad time. Maybe it's not that bad, I just didn't test yet.

To properly handle this, some new UI elements will be needed to enforce the right mode inside the frame and also have the ability to use a different mode for the inspector UI.
@Inwerpsel Inwerpsel added bug Something isn't working needs design Missing design ideas for crucial components needs info The issue probably doesn't have enough information/ideas to be actionable at this time enhancement New feature or request css-feature Adds support for some part of the CSS Spec labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working css-feature Adds support for some part of the CSS Spec enhancement New feature or request needs design Missing design ideas for crucial components needs info The issue probably doesn't have enough information/ideas to be actionable at this time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Inwerpsel