Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth feature #270

Merged
merged 9 commits into from
Mar 29, 2021
Merged

Auth feature #270

merged 9 commits into from
Mar 29, 2021

Conversation

ifonya105
Copy link

fixed auth with the token
added conversation list test
added is_im property
added user property to channel
fixed upload file method
fixed UserUIInteraction test

@mckunda
Copy link

mckunda commented Mar 7, 2021

@ifonya105 Channel already has is_im and user fields, and that's why the appveyor build has failed.

@ifonya105
Copy link
Author

@ifonya105 Channel already has is_im and user fields, and that's why the appveyor build has failed.

yeah, it's strange that I didn't notice it.
I'll fix

@we4sz
Copy link

we4sz commented Mar 16, 2021

When can we expect this? It's blocking my current development :)

@ifonya105
Copy link
Author

Someone please accept the request.

@AdamCLarsen
Copy link

When can we expect this? It's blocking my current development :)

This is blocking my project as well, would be helpful to get this out.

@@ -111,9 +130,18 @@ protected HttpWebRequest CreateWebRequest(Uri requestUri)
return httpWebRequest;
}

protected HttpResponseMessage PostRequest(string requestUri, MultipartFormDataContent form)
protected Task<HttpResponseMessage> PostRequestAsync(string requestUri, MultipartFormDataContent form, string token)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this is the part I take issue with. We have a split client for handling async workflows specifically.

Calling .Result does not work as a way to invoke async from a sync call

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I'm realizing we did do .Result before. Ugh.

@Inumedia Inumedia merged commit 1c51217 into Inumedia:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants