-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth feature #270
Auth feature #270
Conversation
@ifonya105 |
yeah, it's strange that I didn't notice it. |
When can we expect this? It's blocking my current development :) |
Someone please accept the request. |
This is blocking my project as well, would be helpful to get this out. |
@@ -111,9 +130,18 @@ protected HttpWebRequest CreateWebRequest(Uri requestUri) | |||
return httpWebRequest; | |||
} | |||
|
|||
protected HttpResponseMessage PostRequest(string requestUri, MultipartFormDataContent form) | |||
protected Task<HttpResponseMessage> PostRequestAsync(string requestUri, MultipartFormDataContent form, string token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this is the part I take issue with. We have a split client for handling async workflows specifically.
Calling .Result
does not work as a way to invoke async from a sync call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I'm realizing we did do .Result
before. Ugh.
fixed auth with the token
added conversation list test
added is_im property
added user property to channel
fixed upload file method
fixed UserUIInteraction test