Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade plutus to build with ghc-9.6 #5301

Closed
erikd opened this issue May 5, 2023 · 9 comments · Fixed by #5286
Closed

Upgrade plutus to build with ghc-9.6 #5301

erikd opened this issue May 5, 2023 · 9 comments · Fixed by #5286

Comments

@erikd
Copy link
Contributor

erikd commented May 5, 2023

[x] Make it build
[ ] Add it to CI
[x] Upload to CHaP

@github-actions github-actions bot added the status: needs triage GH issues that requires triage label May 5, 2023
@erikd erikd self-assigned this May 5, 2023
@erikd
Copy link
Contributor Author

erikd commented May 5, 2023

PR is #5286

@angerman angerman linked a pull request May 5, 2023 that will close this issue
@angerman
Copy link
Contributor

angerman commented May 5, 2023

@michaelpj would you be able to review this?

@michaelpj
Copy link
Contributor

I'm aware of it. I've also got the CI bit more-or-less ready to go.

I think we might want to make some individual sub-tasks for the stuff we need to do to get it on CHaP. There are a lot of dependencies that need updating.

@angerman
Copy link
Contributor

angerman commented May 5, 2023

@michaelpj

I think we might want to make some individual sub-tasks for the stuff we need to do to get it on CHaP.

fully agreed. @erikd can you create the subtasks? I doubt there are real subtasks in GH, but we can just create multiple tickets and link them here, I believe.

@effectfully effectfully added status: triaged and removed status: needs triage GH issues that requires triage labels May 8, 2023
@michaelpj
Copy link
Contributor

I've narrowed down the problems to just a few. Lots has been fixed on Hackage recently. Listing the remaining ones here:

I've commented/opened issues throughout, will try and act on int-cast soonish.

@erikd
Copy link
Contributor Author

erikd commented May 18, 2023

Still need to upload this to CHaP.

@michaelpj
Copy link
Contributor

We do a release at the end of every sprint.

@erikd
Copy link
Contributor Author

erikd commented May 21, 2023

When is that?

@erikd erikd reopened this May 22, 2023
@github-actions github-actions bot added the status: needs triage GH issues that requires triage label May 22, 2023
@effectfully effectfully added Internal and removed status: needs triage GH issues that requires triage labels May 22, 2023
@michaelpj
Copy link
Contributor

I just did one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants