Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] - Add support for reading checkpoint data #5730

Open
dnadales opened this issue Mar 27, 2024 · 3 comments · May be fixed by #6048
Open

[FR] - Add support for reading checkpoint data #5730

dnadales opened this issue Mar 27, 2024 · 3 comments · May be fixed by #6048
Labels
type: enhancement An improvement on the existing functionality

Comments

@dnadales
Copy link
Member

dnadales commented Mar 27, 2024 •
edited by amesgen
Loading

Internal/External
Internal if an IOHK staff member.

Area
Other Any other topic (Delegation, Ranking, ...).

Describe the feature you'd like

Implement a solution allowing checkpoint data to be provided to the node such that:

  • The checkpoint data contains a list of blocks which must be present in the chain.
  • If we encounter a chain which would exclude a block in this list, we will consider it invalid.

The functionality already exists in Consensus (IntersectMBO/ouroboros-consensus#898), remaining work is to (optionally) parse the relevant checkpoint data and propagate them to Consensus.

Sketch: Optionally, the node config file can contain a path to a file containing the snapshots, eg

20 deadbeef
30 beefdead

indicating checkpoint hashes for block numbers 20 and 30.

Concretely, it needs to be passed here:

cardano-node/cardano-node/src/Cardano/Node/Protocol/Cardano.hs

Lines 240 to 241 in 341ea87

-- TODO: once https://github.com/IntersectMBO/cardano-node/issues/5730 is implemented 'emptyCheckpointsMap' needs to be replaced with the checkpoints map read from a configuration file.
, Consensus.cardanoCheckpoints = emptyCheckpointsMap

@dnadales dnadales added the type: enhancement An improvement on the existing functionality label Mar 27, 2024
This was referenced Apr 2, 2024
Merged
Closed
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Apr 27, 2024
@amesgen amesgen removed the Stale label May 24, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Jun 24, 2024
@amesgen amesgen removed the Stale label Jun 24, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Jul 25, 2024
@amesgen amesgen removed the Stale label Jul 25, 2024
@amesgen amesgen linked a pull request Dec 4, 2024 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement An improvement on the existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optionally support lightweight checkpointing IntersectMBO/cardano-node
2 participants
@dnadales @amesgen