From 89445d3c7f2a7b90c698ef49cbb5b2096ea105f5 Mon Sep 17 00:00:00 2001 From: Michael Steinert <133106264+MichaelSteinert@users.noreply.github.com> Date: Tue, 6 Jun 2023 12:50:34 +0200 Subject: [PATCH 1/9] fix: correct minor typos in model.md --- model/model.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/model/model.md b/model/model.md index c5bec696..b038d4b2 100644 --- a/model/model.md +++ b/model/model.md @@ -46,8 +46,8 @@ elements of the model, i.e. those that are represented in protocol message flows A `Catalog` is a [DCAT Catalog](https://www.w3.org/TR/vocab-dcat-3/#Class:Catalog) with the following attributes: - 0..N `Asset Entries`. Since a catalog may be dynamically generated for a request based on the requesting participant's credentials it is possible for it to contain 0 matching - asset entries. (DCAT PROFILE) -- 1.N [DCAT DataService](https://www.w3.org/TR/vocab-dcat-3/#Class:Data_Service) that references a `Connector` where assets may be obtained. (DCAT PROFILE) + asset entries. (DCAT PROFILE) +- 1..N [DCAT DataService](https://www.w3.org/TR/vocab-dcat-3/#Class:Data_Service) that references a `Connector` where assets may be obtained. (DCAT PROFILE) ### 2.2.2 Asset Entry From aa2982066d5522792ba651cc559b3b8642a60504 Mon Sep 17 00:00:00 2001 From: Michael Steinert <133106264+MichaelSteinert@users.noreply.github.com> Date: Tue, 6 Jun 2023 12:52:39 +0200 Subject: [PATCH 2/9] fix: correct minor typos in catalog.binding.https.md --- catalog/catalog.binding.https.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/catalog/catalog.binding.https.md b/catalog/catalog.binding.https.md index 262ed6f3..14b022e9 100644 --- a/catalog/catalog.binding.https.md +++ b/catalog/catalog.binding.https.md @@ -132,7 +132,7 @@ the [HTTP 1.1 Specification](https://www.rfc-editor.org/rfc/rfc9110.html#name-gz ### 4.1 Asynchronous Interactions -We may want to specify optional support for asynchronous callbacks for the catalog response. This would require addling a `callbackAddress` property and an `@id` to the request: +We may want to specify optional support for asynchronous callbacks for the catalog response. This would require adding a `callbackAddress` property and an `@id` to the request: ``` POST https://provider.com/catalog/request From 4cffb09b863b8220bae2082fe3f3abc7b967b40b Mon Sep 17 00:00:00 2001 From: Michael Steinert <133106264+MichaelSteinert@users.noreply.github.com> Date: Tue, 6 Jun 2023 13:15:46 +0200 Subject: [PATCH 3/9] fix: correct minor typos in terminology.md --- model/terminology.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/model/terminology.md b/model/terminology.md index 4c378211..32a64ae7 100644 --- a/model/terminology.md +++ b/model/terminology.md @@ -26,9 +26,9 @@ An `IdentityProvider` is a trusted technology system that creates, maintains, an A `CredentialIssuer` is a trusted technology system that issues verifiable credentials for a `Participant` and `ParticipantAgents`. -## Observability, Tracability and Audit Logging +## Observability, Traceability and Audit Logging -`Observability, Tracability and Audit Logging` of transactions, e.g. `Contract Negotiation`, `Data Transfer` and enforcement of access policies or usage policies, in a `Data Space` can be a requirement. +`Observability, Traceability and Audit Logging` of transactions, e.g. `Contract Negotiation`, `Data Transfer` and enforcement of access policies or usage policies, in a `Data Space` can be a requirement. If a trusted technology system is required that records and verifies those domain events. This is not in the scope of the current version of the document and is subject of future work. ## DataspaceRegistrationService @@ -57,11 +57,11 @@ A collection of entries representing `Assets` and their `Offers` that is adverti ## CatalogService -A `PariticipantAgent` that makes a `Catalog` accessible to `Participants`. +A `ParticipantAgent` that makes a `Catalog` accessible to `Participants`. ## Connector (DataService) -A `PariticipantAgent` that produces `Agreements` and manages `Asset` sharing. +A `ParticipantAgent` that produces `Agreements` and manages `Asset` sharing. ## Contract Negotiation From ce6f3cf2b0a764c69e1772d0e13b2c6446b1c69e Mon Sep 17 00:00:00 2001 From: Michael Steinert <133106264+MichaelSteinert@users.noreply.github.com> Date: Tue, 6 Jun 2023 13:18:08 +0200 Subject: [PATCH 4/9] fix: change spelling in terminology.md --- model/terminology.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/model/terminology.md b/model/terminology.md index 32a64ae7..98cbafe3 100644 --- a/model/terminology.md +++ b/model/terminology.md @@ -28,7 +28,7 @@ A `CredentialIssuer` is a trusted technology system that issues verifiable crede ## Observability, Traceability and Audit Logging -`Observability, Traceability and Audit Logging` of transactions, e.g. `Contract Negotiation`, `Data Transfer` and enforcement of access policies or usage policies, in a `Data Space` can be a requirement. +`Observability, Traceability and Audit Logging` of transactions, e.g. `Contract Negotiation`, `Data Transfer` and enforcement of access policies or usage policies, in a `Dataspace` can be a requirement. If a trusted technology system is required that records and verifies those domain events. This is not in the scope of the current version of the document and is subject of future work. ## DataspaceRegistrationService From 09824f0d64be7d5377d6dc57a511055836b7a8b5 Mon Sep 17 00:00:00 2001 From: Michael Steinert <133106264+MichaelSteinert@users.noreply.github.com> Date: Tue, 6 Jun 2023 13:21:59 +0200 Subject: [PATCH 5/9] fix: correct minor typos in model.md --- model/model.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/model/model.md b/model/model.md index b038d4b2..fa12c58a 100644 --- a/model/model.md +++ b/model/model.md @@ -12,9 +12,9 @@ The relationships between the primary dataspace entities are defined as follows: Note that all relationships are multiplicities unless specified. -- A `Dataspace Authority` manges one or more `Dataspaces`. This will include participant registration and may entail mandating business and/or requirements. For example, a +- A `Dataspace Authority` manages one or more `Dataspaces`. This will include participant registration and may entails mandating business and/or requirements. For example, a Dataspace Authority may require participants to obtain some form of business certification. A Dataspace authority may also impose technical requirements such as support for the - technical enforcements of specific usage policies. + technical enforcement of specific usage policies. - A `Participant` is a member of one or more `Dataspaces`. A participant registers `Participant Agents` that perform tasks on its behalf. - A `Participant Agent` performs tasks such as publishing a catalog or engaging in an asset transfer. In order to accomplish these tasks, a participant agent may use a _**verifiable presentation**_ generated from a _**credential**_ obtained from a third-party issuer. A participant agent may also use an _**ID token**_ issued by a From e0442bf2ff01fdf2c5ccac6ad1f4764c8d1ef53d Mon Sep 17 00:00:00 2001 From: Michael Steinert <133106264+MichaelSteinert@users.noreply.github.com> Date: Tue, 6 Jun 2023 13:24:56 +0200 Subject: [PATCH 6/9] fix: added missing comma in catalog.binding.https.md --- catalog/catalog.binding.https.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/catalog/catalog.binding.https.md b/catalog/catalog.binding.https.md index 14b022e9..0299ee70 100644 --- a/catalog/catalog.binding.https.md +++ b/catalog/catalog.binding.https.md @@ -37,7 +37,7 @@ Authorization: ... { "@context": "https://w3id.org/dspace/v0.8/context.json", - "@type": "dspace:CatalogRequest" + "@type": "dspace:CatalogRequest", "dspace:filter": {} } ``` From a9eb1b52487393a381df3d5145d419eb585c9219 Mon Sep 17 00:00:00 2001 From: Michael Steinert <133106264+MichaelSteinert@users.noreply.github.com> Date: Tue, 6 Jun 2023 13:33:54 +0200 Subject: [PATCH 7/9] fix: add missing word in contract.negotiation.binding.https.md --- negotiation/contract.negotiation.binding.https.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/negotiation/contract.negotiation.binding.https.md b/negotiation/contract.negotiation.binding.https.md index 98bf6a4f..fa351438 100644 --- a/negotiation/contract.negotiation.binding.https.md +++ b/negotiation/contract.negotiation.binding.https.md @@ -210,7 +210,7 @@ Authorization: ... } ``` -If the message is successfully processed, consumer provider connector must return and HTTP 200 (OK) response. The response body is not specified and clients are not required to +If the message is successfully processed, the consumer provider connector must return an HTTP 200 (OK) response. The response body is not specified and clients are not required to process it. ### 3.3 The consumer `negotiations/:id/agreement` resource From 56d61d97019ec570b1a4f8bd8f3e75f9c8bbadaa Mon Sep 17 00:00:00 2001 From: Michael Steinert <133106264+MichaelSteinert@users.noreply.github.com> Date: Tue, 6 Jun 2023 14:51:56 +0200 Subject: [PATCH 8/9] fix: change spellling in contract.negotiation.protocol.md --- negotiation/contract.negotiation.protocol.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/negotiation/contract.negotiation.protocol.md b/negotiation/contract.negotiation.protocol.md index 853dbc3a..7f18d610 100644 --- a/negotiation/contract.negotiation.protocol.md +++ b/negotiation/contract.negotiation.protocol.md @@ -173,7 +173,7 @@ When the `ContractNegotiationEventMessage` is sent by a provider with an `eventT is accessible. The state machine is transitioned to the `FINALIZED` state. Other event types may be defined in the future. A consumer responds with an error if the signature can't be validated or is incorrect. -It is an error for a consumer to send a `ContractNegotiationEventMessage` with an eventType `finalized` to the provider. +It is an error for a consumer to send a `ContractNegotiationEventMessage` with an eventType `FINALIZED` to the provider. When the `ContractNegotiationEventMessage` is sent by a consumer with an `eventType` set to `ACCEPTED`, the state machine is placed in the `ACCEPTED` state. From 185562ec883f7428b890ac9df8e29371841bd238 Mon Sep 17 00:00:00 2001 From: Michael Steinert <133106264+MichaelSteinert@users.noreply.github.com> Date: Mon, 12 Jun 2023 14:03:23 +0200 Subject: [PATCH 9/9] Update model/model.md Co-authored-by: Julia Pampus <72392527+juliapampus@users.noreply.github.com> --- model/model.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/model/model.md b/model/model.md index fa12c58a..26b6772f 100644 --- a/model/model.md +++ b/model/model.md @@ -12,7 +12,7 @@ The relationships between the primary dataspace entities are defined as follows: Note that all relationships are multiplicities unless specified. -- A `Dataspace Authority` manages one or more `Dataspaces`. This will include participant registration and may entails mandating business and/or requirements. For example, a +- A `Dataspace Authority` manages one or more `Dataspaces`. This will include participant registration and may entail mandating business and/or requirements. For example, a Dataspace Authority may require participants to obtain some form of business certification. A Dataspace authority may also impose technical requirements such as support for the technical enforcement of specific usage policies. - A `Participant` is a member of one or more `Dataspaces`. A participant registers `Participant Agents` that perform tasks on its behalf.