Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing dataset property in Dataset Request Message #199

Closed
juliapampus opened this issue Jan 16, 2024 · 2 comments · Fixed by #184
Closed

Missing dataset property in Dataset Request Message #199

juliapampus opened this issue Jan 16, 2024 · 2 comments · Fixed by #184
Labels
V1 pre-release These things must be fixed before pre-releasing V1 of the DSP
Milestone
V1 pre-release

Comments

@juliapampus
Copy link
Contributor

The schemes and shapes for the DatasetRequestMessage and the CatalogRequestMessage look alike although the spec states:

The DatasetRequestMessage must have a Dataset property which contains the id of the Dataset.
@juliapampus juliapampus added the V1 pre-release These things must be fixed before pre-releasing V1 of the DSP label Jan 16, 2024
@ssteinbuss
Copy link
Member

need to be addressed in the editorial rework branch, see #184
https://github.com/International-Data-Spaces-Association/ids-specification/blob/editorial-rework/catalog/message/diagram/dataset-request-message.png

@sebbader-sap
Copy link
Contributor

I can confirm, fixed with 815aedc

@ssteinbuss ssteinbuss added this to the V1 pre-release milestone Feb 1, 2024
@juliapampus juliapampus linked a pull request Feb 6, 2024 that will close this issue
Editorial Rework #184
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
V1 pre-release These things must be fixed before pre-releasing V1 of the DSP
Projects
None yet
Milestone
V1 pre-release
Development

Successfully merging a pull request may close this issue.

Editorial Rework International-Data-Spaces-Association/ids-specification
3 participants
@ssteinbuss @juliapampus @sebbader-sap