Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in ContractRequestMessage #198

Closed
juliapampus opened this issue Jan 16, 2024 · 8 comments
Closed

Inconsistency in ContractRequestMessage #198

juliapampus opened this issue Jan 16, 2024 · 8 comments
Assignees
Labels
V1 pre-release These things must be fixed before pre-releasing V1 of the DSP

Comments

@juliapampus
Copy link
Contributor

In the procotol, we define that a ContractRequestMessage contains either a dspace:offer or dspace:offerId. This is not reflected in the schema.

@juliapampus juliapampus added the V1 pre-release These things must be fixed before pre-releasing V1 of the DSP label Jan 16, 2024
@matgnt
Copy link
Collaborator

matgnt commented Jan 18, 2024

@juliapampus where exactly? I can't find the text that allows dspace:offerId

@juliapampus
Copy link
Contributor Author

@matgnt Oh sry, wrong link.. here is the section: https://github.com/International-Data-Spaces-Association/ids-specification/blob/main/negotiation/contract.negotiation.binding.https.md#261-post

@juliapampus
Copy link
Contributor Author

The consumer must include the providerPid and consumerPid. The consumer must include either the offer or offerId property.

@juliapampus
Copy link
Contributor Author

could be a leftover?

@IgorBalog-Eng
Copy link

While we review this file, there are broken json examples, that are missing comma at the end

{
"@context": "https://w3id.org/dspace/v0.8/context.json",
"@type": "dspace:ContractRequest" <----- here missing comma
"dspace:consumerPid": "urn:uuid:32541fe6-c580-409e-85a8-8a9a32fbe833",

and also in next json example and
3.2.1 POST
"@context": "https://w3id.org/dspace/v0.8/context.json",
"@type": "dspace:ContractOfferMessage" <--- here
"dspace:providerPid": "urn:uuid:dcbf434c-eacf-4582-9a02-f8dd50120fd3",

and its response example

@ssteinbuss
Copy link
Member

should be fixed with #184

@ssteinbuss ssteinbuss added this to the V1 pre-release milestone Feb 1, 2024
@juliapampus juliapampus self-assigned this Feb 8, 2024
@juliapampus
Copy link
Contributor Author

will check again before closing the issue

@juliapampus
Copy link
Contributor Author

I can't find any more inconsistencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V1 pre-release These things must be fixed before pre-releasing V1 of the DSP
Projects
None yet
Development

No branches or pull requests

4 participants