Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mvds visual #127

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update mvds visual #127

wants to merge 4 commits into from

Conversation

anilturkmayali
Copy link
Member

MVDS Visual has been updated with a newer and more modern version of it.

New visual for MVDS
Changed the link to new MVDS visual
@anilturkmayali anilturkmayali added the documentation Improvements or additions to documentation label May 22, 2023
Copy link
Member

@ssteinbuss ssteinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The figure is not correct:

  1. typo in Identity provider
  2. DAPS has 2 arrows to Connector A but only one to Connector B
  3. The CA issues the certificate to connector A, the arrow is not labeled
  4. Label of DAPS: manages ... participants, here more or less connectors in this figure?

Updated mvds visual
Updated the visual with newer version.
@anilturkmayali anilturkmayali requested a review from ssteinbuss June 9, 2023 11:36
@anilturkmayali
Copy link
Member Author

The figure is not correct:

  1. typo in Identity provider
  2. DAPS has 2 arrows to Connector A but only one to Connector B
  3. The CA issues the certificate to connector A, the arrow is not labeled
  4. Label of DAPS: manages ... participants, here more or less connectors in this figure?

Changes have been applied in the newer version of the visual. Could you please review again?
@ssteinbuss @Sonia-IDSA

Thank you,
Best wishes,
Anil

@jfernandezsqs
Copy link
Member

I have reviewed the PR.
In the mvds-visual.png file it appears two outgoing arrows from DAPS to ConnectorA. It should be one incoming and one outgoing, as it is for DAPS-ConnectorB interaction arrows.
There is a label “Issues certificate” for DAPS-ConnectorA and DAPS-ConnectorB, is this label correctly assigned there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants