Enable more lenient parsing of report descriptor on Windows. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HidSharp has trouble parsing some report descriptors on Windows. This makes some devices unusable with HidSharp. By discarding report items which overlap or report items having undefined usage values (0) we enable more lenient parsing. This makes HidSharp usable with more devices.
|
Please remove any unneeded whitespace changes from the commit. |
Joop-Schilder
force-pushed
the
fix-report-descriptor-reconstruction-fails-on-windows
branch
from
6b83ab5 to
2079edb
Compare
Joop-Schilder
force-pushed
the
fix-report-descriptor-reconstruction-fails-on-windows
branch
from
2079edb to
148a3c0
Compare
Done! I usually leave an empty line below my |
|
I have done some minor changes and pushed your commit to master. There is no style guide, since I'm not the author, and I have no resources to manage this library properly. I did extend the single line branches so it's easier to debug if that branch is entered, and I can recommend that practice to you as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HidSharp has trouble parsing some report descriptors on Windows. This makes some devices unusable with HidSharp. By discarding report items which overlap or report items having undefined usage values (0) we enable more lenient parsing. This makes HidSharp usable with more devices.
This pull request fixes #18. We are still testing this.