Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Error: PMGD Metadata for descriptor set may be stored even if descriptor set creation fails #219

Open
ifadams opened this issue Sep 16, 2024 · 0 comments
Assignees
Labels
Bug Indicates unexpected or undesired behaviors Discussion Needed Require additional context and discussion
Milestone

Comments

@ifadams
Copy link
Contributor

ifadams commented Sep 16, 2024

Describe the bug
This is based on code reading, so still needs some additional checks to verify.

Basically, when we add a new descriptor set, we do the metadata operations first (construct protobuf), if these succeed, we then proceed to create the descriptor set (construct response).

However, given that metadata is committed before we attempt to create the descriptor set, we may wind up in an inconsistent state as theres no easy way to roll back a metadata commit with the PMGD based handler.

To Reproduce

NEED TO VERIFY

Add two named descriptor sets with identical names and engines in separate transactions, the second add should should fail.

Then query for the all metadata affiliated with a descriptor set, and if we see multiple node responses we'll know this is an active bug.

Expected behavior

We should block metadata from being created if a descriptor set is already in existence, and ideally if descriptor set creation fails, however this may be tricky for the PMGD based handler.

@ifadams ifadams added Bug Indicates unexpected or undesired behaviors Discussion Needed Require additional context and discussion labels Sep 16, 2024
@ifadams ifadams self-assigned this Sep 16, 2024
@cwlacewe cwlacewe added this to the v2.11.0 Tasks milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Indicates unexpected or undesired behaviors Discussion Needed Require additional context and discussion
Projects
None yet
Development

No branches or pull requests

2 participants