Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: max_neighbors argument in PeriodicPropertiesTransform is unused #336

Open
laserkelvin opened this issue Dec 20, 2024 · 0 comments
Open

[Bug]: max_neighbors argument in PeriodicPropertiesTransform is unused #336

laserkelvin opened this issue Dec 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@laserkelvin
Copy link
Collaborator

Expected behavior

max_neighbors should semantically filter out edges once a node has exceed its allowed quantity.

Actual behavior

As of #335, the branching will skip the max_neighbors logic entirely since it operates on the keep set of Edge objects.

Steps to reproduce the problem

Changing max_neighbors will not affect the result when is_undirected=False.

Specifications

N/A
@laserkelvin laserkelvin added the bug Something isn't working label Dec 20, 2024
@laserkelvin laserkelvin mentioned this issue Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laserkelvin