Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular import issue with Adversary reference #38

Closed
lumurillo opened this issue Jan 3, 2023 · 4 comments
Closed

Circular import issue with Adversary reference #38

lumurillo opened this issue Jan 3, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@lumurillo
Copy link
Contributor

When trying to reference the Adversary type in the Callback interface it provokes a import circular issue.
@lumurillo lumurillo added the enhancement New feature or request label Jan 3, 2023
This was referenced Jan 3, 2023
Merged
Closed
@dxoigmn
Copy link
Contributor

dxoigmn commented Jan 9, 2023

Can you document the issue better? That will make it easier to review the associated PR.

@lumurillo
Copy link
Contributor Author

The problem is that since Adversary make use of the Callback class, and the Callback base class also make use of the Adversary class; when adding the typing hints this is provoking a circular import issue.

@dxoigmn
Copy link
Contributor

dxoigmn commented Jan 9, 2023

Do you have a PR that exhibits this issue? Easier for me to read code and make suggestions than interpret english descriptions of code.

@lumurillo
Copy link
Contributor Author

Last commit in PR #29 solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Adversary interaction with Callbacks IntelLabs/MART
2 participants
@dxoigmn @lumurillo