-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two questions about IGListSingleSectionController? #480
Comments
@PhilCai1993 this would be a nice enhancement. No, the configure block should be I'm open to the selection change, making that a The only concern w/ the selection part being a block is it will be prone to retain cycles, since I'd imagine consumers will access other state in that method. For instance, if a view controller created the single section controller and did something like Writing it out, I'm probably still opposed to changing that API. |
@rnystrom For example:
|
@PhilCai1993 I like that! You could lookup the object using |
Close #397 |
Is it necessary to make
configureBlock
nonnull?When initialize
IGListSingleSectionController
, aconfigureBlock
is required to be nonnull.But sometimes it's not required. For example, when
listAdapter:sectionControllerForObject:
is invoked to return a sectionController, ifobject
is some special object, it is not necessary to config the sectionController using theobject
(such a static cell).How about adding a
didSelectSingleSectionHandler
to be an alternative toIGListSingleSectionControllerDelegate
since we haveconfigureBlock
andsizeBlock
?In this way, it's of benefit to write codes together. Of course it's not difficult to customize a
IGListBlockSupportedSingleSectionController
if needed.😄The text was updated successfully, but these errors were encountered: