You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Whenever a batch update comes in with a delete and a move-from in the same section, we convert the move to a delete+insert. This is probably wrong b/c the data source count will likely change (b/c of the delete) but since we gather deletes in an NSIndexSet, only one delete will occur along w/ an insert from the move conversion.
Whenever a batch update comes in with a delete and a move-from in the same section, we convert the move to a delete+insert. This is probably wrong b/c the data source count will likely change (b/c of the delete) but since we gather deletes in an
NSIndexSet
, only one delete will occur along w/ an insert from the move conversion.https://github.com/Instagram/IGListKit/blob/master/Source/Common/IGListBatchUpdateData.mm#L92-L93
So pseudocode illustrating the problem:
Instead, we should drop the move entirely so only the delete wins. That way the expected data source changes are reflected w/ the batch update.
The text was updated successfully, but these errors were encountered: