Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reloadIndexPaths: from IGListBatchUpdateData #429

Closed
rnystrom opened this issue Jan 18, 2017 · 3 comments
Closed

Remove reloadIndexPaths: from IGListBatchUpdateData #429

rnystrom opened this issue Jan 18, 2017 · 3 comments
Assignees
@rnystrom
Labels
enhancement
Milestone
3.0.0

Comments

@rnystrom
Copy link
Contributor

rnystrom commented Jan 18, 2017 •
edited by jessesquires
Loading

Blocked by #418

We should remove the ability to call -[UICollectionView reloadIndexPaths:] completely since we are trying to force everything to go through performBatchUpdates:

https://github.com/Instagram/IGListKit/blob/master/Source/Internal/UICollectionView%2BIGListBatchUpdateData.m#L19
@rnystrom rnystrom self-assigned this Jan 18, 2017
@jessesquires jessesquires added this to the 3.0.0 milestone Jan 20, 2017
@jessesquires
Copy link
Contributor

is this a breaking change?

@rnystrom
Copy link
Contributor Author

@jessesquires I don't think so, only breaking internally

@rnystrom
Copy link
Contributor Author

Will also happen when #392 lands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnystrom rnystrom

Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@rnystrom @jessesquires