Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide IGListCollectionSectionController [inception] #31

Closed
rnystrom opened this issue Sep 19, 2016 · 10 comments
Closed

Provide IGListCollectionSectionController [inception] #31

rnystrom opened this issue Sep 19, 2016 · 10 comments
Labels

Comments

@rnystrom
Copy link
Contributor

Create a stock horizontal or vertical scrolling item controller. This is a pretty loaded RFC b/c the API would have to be really thought out. Some questions come to mind:

Subclassing?

Since the infra requires subclassing IGListItemController and conforming to IGListItemType, if we provide a new item controller for this it would have to follow the same pattern as the stacked or single item controller:

@interface IGListCollectionItemController : IGListItemController <IGListItemType>
@end

Question is: do we have clients subclass this object or do we stick SUBCLASSING_RESTRICTED on it and provide some hooks?

Another idea is that we don't conform to IGListItemType but add hooks to properly setup/configure/reload the embedded item controller.

UICollectionView config

  • Should we have an enum for h/v scrolling?
  • What layout object would we use?
    • Maybe we keep the stock version of this to using UICollectionViewFlowLayout

I'm sure there will be more questions that come up. Open to suggestions.

@jessesquires
Copy link
Contributor

jessesquires commented Oct 13, 2016

To clarify a bit:

What we want to achieve is to have multiple sections with horizontal scrolling that together scroll vertical. Essentially, a ListKit version of https://github.com/ashfurrow/AFTabledCollectionView. So IGListCollectionSectionController would be a section that contains a (horizontally scrolling) collection view.

Correct, @rnystrom ? (At least, that's part of this proposal)

@jessesquires jessesquires changed the title Provide IGListCollectionItemController Provide IGListCollectionSectionController Oct 13, 2016
@zhubofei
Copy link

zhubofei commented Oct 26, 2016

@rnystrom IGListItemControllerwas renamed to IGListSectionController right?

@jessesquires
Copy link
Contributor

@zhubofei - correct 😄 We should update the initial comment

@rnystrom
Copy link
Contributor Author

Noting from #133 that we want to store and reset the content offset of the collection view when it is reused.

@jessesquires jessesquires changed the title Provide IGListCollectionSectionController Provide IGListCollectionSectionController [inception] Oct 31, 2016
@rnystrom rnystrom added this to the 3.0.0 milestone Jan 4, 2017
@jessesquires
Copy link
Contributor

@rnystrom - can this be deferred from 3.0 to a later release?

@rnystrom
Copy link
Contributor Author

@jessesquires we could sneak it in, honestly, now that #517 and #503 are under wraps. Probably ok to punt tho since there's enough documentation right now.

@jessesquires jessesquires modified the milestones: 3.1.0, 3.0.0 Feb 28, 2017
@jessesquires
Copy link
Contributor

@rnystrom - Cool let's push this to 3.1.0

@rnystrom rnystrom modified the milestones: 3.2.0, 3.1.0 Aug 9, 2017
@tunidev
Copy link

tunidev commented Oct 17, 2017

any news about that

@rnystrom rnystrom modified the milestones: 3.2.0, 3.3.0 Jan 29, 2018
@jessesquires jessesquires modified the milestones: 3.3.0, 3.4.0 Apr 23, 2018
@jessesquires jessesquires modified the milestones: 3.4.0, 3.5.0 Jul 9, 2018
@jessesquires jessesquires removed this from the 3.5.0 milestone Jul 9, 2018
@jessesquires
Copy link
Contributor

Clearing the milestone here since this seems like it's still in the pretty early stages of design, etc

@Ziewvater
Copy link

There isn't much call for something like this internally, so we're not going to invest effort in building it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants