-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide IGListCollectionSectionController [inception] #31
Comments
To clarify a bit: What we want to achieve is to have multiple sections with horizontal scrolling that together scroll vertical. Essentially, a ListKit version of https://github.com/ashfurrow/AFTabledCollectionView. So Correct, @rnystrom ? (At least, that's part of this proposal) |
@rnystrom |
@zhubofei - correct 😄 We should update the initial comment |
Noting from #133 that we want to store and reset the content offset of the collection view when it is reused. |
@rnystrom - can this be deferred from 3.0 to a later release? |
@jessesquires we could sneak it in, honestly, now that #517 and #503 are under wraps. Probably ok to punt tho since there's enough documentation right now. |
@rnystrom - Cool let's push this to 3.1.0 |
any news about that |
Clearing the milestone here since this seems like it's still in the pretty early stages of design, etc |
There isn't much call for something like this internally, so we're not going to invest effort in building it out. |
Create a stock horizontal or vertical scrolling item controller. This is a pretty loaded RFC b/c the API would have to be really thought out. Some questions come to mind:
Subclassing?
Since the infra requires subclassing
IGListItemController
and conforming toIGListItemType
, if we provide a new item controller for this it would have to follow the same pattern as the stacked or single item controller:Question is: do we have clients subclass this object or do we stick
SUBCLASSING_RESTRICTED
on it and provide some hooks?Another idea is that we don't conform to
IGListItemType
but add hooks to properly setup/configure/reload the embedded item controller.UICollectionView config
UICollectionViewFlowLayout
I'm sure there will be more questions that come up. Open to suggestions.
The text was updated successfully, but these errors were encountered: