Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyre Failing on master branch #186

Closed
lisroach opened this issue Apr 22, 2021 · 1 comment
Closed

Pyre Failing on master branch #186

lisroach opened this issue Apr 22, 2021 · 1 comment

Comments

@lisroach
Copy link
Contributor

Pyre failed due to a type error was found in fixit/rules/cls_in_classmethod.py:286:26 and that's related to the new LibCST release.
https://github.com/Instagram/Fixit/runs/2271833508
The same issue happens on master branch and it's better to fix it before merging new PRs.
FlattenSentinel is added in LibCST 0.3.18 and we need to update the type annotation of report().

replacement: Optional[Union[cst.CSTNode, cst.RemovalSentinel]] = None,

Originally posted by @jimmylai in #182 (comment)

@lisroach
Copy link
Contributor Author

Fixed with #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant