Enhanced "join" interface fixes #35 #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default remote IP can now be set through the settings Popup/prompt for IP, port and password now auto-fill from the defaults
AMacro
changed the title
AMacro
changed the title
Insprill
requested changes
May 12, 2024
|
I've also realised this doesn't completely result #35 and I'm looking into the issue to allow a null password, and will add another commit. |
Separated server and client settings
|
I've now confirmed a blank password can be used. |
|
Tested this yesterday, works well! |
|
This PR has now been superseded by #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default remote IP can now be set through the settings
Popup/prompt for IP, port and password now auto-fill from the defaults
Fixes #35