Visualize #50
Visualize #50
Conversation
Required for earlier version of ITK before itkBuildInformation.h was added.
Addresses: examples/Core/CMakeFiles/ThreadOverheadBenchmark.dir/ThreadOverhead.cxx.o: In function `main': ThreadOverhead.cxx:(.text.startup+0x79): undefined reference to `ReplaceOccurrence(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&&)'
This is required for TBB
|
Wow, looking great. You rock. This provides real insight into ITK itself ! |
| @@ -114,6 +114,7 @@ def build_itk(itk_src, itk_bin): | |||
| '-DCMAKE_CXX_STANDARD:STRING=11', | |||
| '-DBUILD_TESTING:BOOL=OFF', | |||
| '-DBUILD_EXAMPLES:BOOL=OFF', | |||
| '-DBUILD_SHARED_LIBS:BOOL=ON', | |||
There was a problem hiding this comment.
I don't think this is required for TBB. I have been using TBB without this most of the time.
There was a problem hiding this comment.
Yes, I think that is correct. I added this in an attempt to address some odd CMake warnings, however, I think it is unrelated.
But, since this does not hurt, and it should improve link time for historical benchmark tests, I will leave it.
|
This looks good. |
It is expected that the command line arguments are full paths. Automatically convert the full paths.
|
The script I have not getting ITK to work with TBB yet. Here is what I was able to get on my system:
|
Add conversion to full paths
|
@blowekamp that is great! I am really interested to see how what the performance looks like with the 88-core system and TBB. Were you able to get the TBB build going? We should help them improve their |
|
I was able to build and test itk with tbb but not use itk with tbb in another project. I made some notes on the confab about it. I also made the patch: |
|
@blowekamp It looks like @dzenanz set up the TBB-ITK CMake configuration well. However, SimpleITK should set |
Some initial benchmark results from the thread pool merge by @dzenanz following the JSON storage by @hjmjohnson and plotting by @jhlegarreta .
This is a plot for revisions, but in the future we could make historical and thread-count.
I will not be able to put further time into this for the remainder of the week.
Find an initial version here.