Create a 5.4.1 patch tag

[blowekamp]

Can we please consider doing a 4.5.1 patch tag?

I am encountering the libtiff duplicate symbol issues in a few builds. This has been patched in the release branch. Additionally it fixes some race conditions and other build issues. Additionally there are some typedefs for forwards compatibility.

This would allow an official SimpleITK release against a tag and to update the conda-forge version of ITK to a tag that is more robustly building.

[dzenanz]

I second this. It is also useful for remote modules which want to build with legacy off, e.g. InsightSoftwareConsortium/ITKMontage#234.

[dzenanz]

Of course, we should consider whether we want to add any other patches to release branch before tagging it.

[thewtex]

Yes. I will work on a v5.4.1 tag tomorrow.

@InsightSoftwareConsortium/community please create PR's for any patches for ITK 5.4.1 to the release-5.4 branch today, and for 5.4.2 over the coming weeks.

[N-Dekker]

Thanks Matt! It would be nice to include the following little bug fix with v5.4.1:

• BUG: QuadEdgeMeshPoint should be properly initialized by {} #4890 commit 789543f

[thewtex]

@N-Dekker thanks for the note!

Done: ef7521d

[dzenanz]

@blowekamp should 6336380 be included?

[blowekamp]

@blowekamp should 6336380 be included?

No, that was after the libtiff update.

The reference tiff issue was addressed in the release branch with 6025654

[dzenanz]

I don't have anything else to nominate.

[blowekamp]

We already have a patch to suppress some TIFF warnings in the release branch. That patch that remove the DICOM monochrome warnings should also be considered:
d29cca5

While training with large datasets I have seen this warnings 100k of times.

[thewtex]

@blowekamp 👍 added.

[thewtex]

Tag: https://github.com/InsightSoftwareConsortium/ITK/releases/tag/v5.4.1

[jamesobutler]

Looks like the tag unfortunately is a commit title detailing 5.3.1(016fd31) although the code defines the version as 5.4.1. Unclear if that is something that can be fixed.

[thewtex]

@jamesobutler Yes, there is an error in that commit message, but the tag is correct. We cannot change the content of a commit after it mas been merged.

[thewtex]

I will follow-up in a different issue on the other release items.

[blowekamp]

@thewtex Should we do a complete 5.3.2 tag with the other critical bug fixes added right after the 5.3.1 tag?

[thewtex]

@blowekamp yes, done: https://github.com/InsightSoftwareConsortium/ITK/releases/tag/v5.4.2

[N-Dekker]

@thewtex Can you please also make a v6.0a02 tag that includes those critical bug fixes? The first v6.0 alpha (v6.0a01) basically appears unusable because it does not yet have the fix for those TIFF link errors (issue #4820).