Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Link for Koin Channel and Twitter #125

Closed
Fuhrmann opened this issue May 11, 2018 · 3 comments
Closed

Documentation: Link for Koin Channel and Twitter #125

Fuhrmann opened this issue May 11, 2018 · 3 comments
Labels
status:accepted accepted to be developed type:issue
Milestone

Comments

@Fuhrmann
Copy link

Describe the bug
There are 3 dead links I've found: one in the README which points to Koin channel (https://kotlinlang.org/messages/koin), one in the footer section of the documentation to your twitter page, and the Slack icon (in the docs, header) points to another link (https://slack.kotlinlang.org/messages/koin) that does not seems to work, I get this message:

Cannot GET /messages/koin

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://github.com/Ekito/koin'
  2. Click on 'Come on slack Koin channel from Kotlin slack'
  3. See error

Expected behavior
Should redirect to the pages.

Additional context
Sorry, I could not found the source code for the documentation so I did not send a pull request.
And the slack channel I don't know the correct URL.

Thanks.

@arnaudgiuliani
Copy link
Member

Thanks for reporting the problem. We can't just provide the url as usual :/

@arnaudgiuliani arnaudgiuliani added this to the 1.0.0 milestone May 16, 2018
@arnaudgiuliani
Copy link
Member

Fixed :)

@Fuhrmann
Copy link
Author

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted accepted to be developed type:issue
Projects
None yet
Development

No branches or pull requests

2 participants