-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming of operation outputs (bool_var
)
#333
Comments
This behaviour is not inconsistent with the specification. Nevertheless the specification is out of my point of view a bit less strict in these cases (reference manual p. 47 f.):
Would it not be better to enforce these defaults, to ensure compatibility between different engines and remove the explicit allowment for personalized default names, which may have lead to the failures of some of our test cases? |
Using a variable name derived from the input sound good in theory, but in practice any expression with more than one variable cannot use this mechanism: We "could" analyse the expression and see if there's only on variable in the tree, but in the end if a variable passes a couple of functions and operators, is keeping the same name really something that is desired? AFAIR the spec switches from one convention to another. Some operators have their own names and other rely on the global convention. This should be clarified in the spec & function definitions. And the TCK should tests these cases. |
|
@NicoLaval as mentioned in my previous comment, the reference manual seems to only recommend the output name for such cases. You are using these recommendations, which is totally matching the specification. Nevertheless, i think it would be useful, to ensure these names also in the VTL specification, to ensure the compatibility between different engines. |
@noahboerger you reported:
In trevas the result of a logical operation is called bool_var instead of having the same name as the input column
Any example inconsistent with the specification?
The text was updated successfully, but these errors were encountered: