Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questionnaire composition - UI concept #561

Closed
romaintailhurat opened this issue Feb 14, 2022 · 12 comments
Closed

Questionnaire composition - UI concept #561

romaintailhurat opened this issue Feb 14, 2022 · 12 comments
Assignees
Labels
Area: Refonte P3 ticket pour le refonte Pogues

Comments

@romaintailhurat
Copy link
Collaborator

Here is a first and very simple concept of the UI part of questionnaires composition:

image

The main idea here is to provide another kind of structural element for the questionnaire : a link to another questionnaire.

The element itself could be name after the target questionnaire. Editing this element display a UI where the designer can specify if its the whole questionnaire or a part of it that is integrated.

@romaintailhurat romaintailhurat added the Area: Refonte P3 ticket pour le refonte Pogues label Feb 14, 2022
@romaintailhurat romaintailhurat self-assigned this Apr 15, 2022
@romaintailhurat
Copy link
Collaborator Author

romaintailhurat commented Apr 15, 2022

Specification

When not specified, the ref element is at the same level than a sequence element, and has the same behaviour

Add a ref

  • click the add element button
  • in the questionnaire list, choose a questionnaire,
  • then click the add button
  • a ref element is added to the questionnaire

Delete a ref

  • Focus on the ref element
  • a Delete button appears at the right end of the element
  • click on the delete button
  • the ref element is deleted

Move a ref

  • specific behavior: the ref element cannot be put under a sequence or a subsequence
  • display only legitimate position
  • ⚠️ currently we keep the existing display, too costly to customise
  • when dropping, the element will be move to the closest possible location (before or after the current displayed position)

Adding other elements

Once added

Ref questionnaire vars are available

  • they can be used as any other variables
  • collected variables
  • ref questionnaire computed variables are added to the computed variable panel
  • same for external variables (does it have a sense ?)
    → it doesn't make sense in the current UI for computed and external variables, though it would in a future Pogues where there is a dedicated and global variables page where all variables are listed.

Updates

  • First implementation: refs vars are updated when loading the questionnaire
  • Second implementation: adding a update button ♻️

Checks

Regular name checks

Sequences, questions, variables, etc.

Reference checks

  • When loading the questionnaire or through the update button ♻️ , check if a reference is still valid (it exists)
    • if not anymore, mark the ref element as not existing, the user will update or change this ref manually, or delete it

@romaintailhurat
Copy link
Collaborator Author

romaintailhurat commented Apr 25, 2022

Adding a element - button placement

image

Adding an element - choice

image

ℹ️ Note the correct items of the choices list are (in 🇫🇷):

  • "Référence au TCM"
  • "Référence à un questionnaire"
  • "Fusion avec un questionnaire"

TCM module choice

image

Note: here, we want a new page, not a modal window.

TCM module configuration

more discussions with TCM manager is needed here.

Module reference display

image

Colore ref is #e7a10b

@romaintailhurat
Copy link
Collaborator Author

Progress have been made; currently a difficult part, handling the drag and drop algorithm for a reference object

@romaintailhurat
Copy link
Collaborator Author

romaintailhurat commented Jun 17, 2022

First experience with composition UI

Global comments

  • the external elements choice panel should be closer to the button (see what we have for the visualisation feature)

1 - Adding a ref to an empty questionnaire

It works, but we still have a warning message (see below) whereas we should not (the ref is indeed adding at least a sequence and a question).

image

2 - Moving the reference element in the questionnaire structure

Moving a reference element is nicely handle: the ref can only be placed at the sequence level, ie not inside a sequence or sub sequence.

3 - Deletion

OK 👍

@loichenninger
Copy link
Contributor

The warning message for a questionnaire too short does not appear anymore on the screen if the questionnaire is composed of only an external reference.

@romaintailhurat
Copy link
Collaborator Author

@loichenninger TODO Provide a cost estimation of implementing sequence integration (from a catalog questionnaire)

@loichenninger
Copy link
Contributor

loichenninger commented Jul 21, 2022

@romaintailhurat What is the behaviour wanted if a questionnaire contains a reference that does not exist anymore?

@romaintailhurat
Copy link
Collaborator Author

@romaintailhurat What is the behaviour wanted if a questionnaire contains a reference that does not exist anymore?

Spec updated 😄

@romaintailhurat
Copy link
Collaborator Author

romaintailhurat commented Jul 29, 2022

UI for a non-existing ref:

image

Color is #dadadb

EDIT: ref in #626

@romaintailhurat
Copy link
Collaborator Author

In order to be compliant with the spec (see above):

  • the option list for adding an external element should be at the same distance from the button than the generation target list from the "Visualize" button
  • we also need to delete the "+ Questionnaire" button in favor of a 3rd external element.

Note: here are the missing translations for the external elements ⬇️

  • TCM reference
  • Questionnaire reference
  • Questionnaire merging

@romaintailhurat
Copy link
Collaborator Author

In order to be compliant with the spec (see above):

  • the option list for adding an external element should be at the same distance from the button than the generation target list from the "Visualize" button

  • we also need to delete the "+ Questionnaire" button in favor of a 3rd external element.

Thank you @BulotF, those two issues are fixed!

@romaintailhurat
Copy link
Collaborator Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Refonte P3 ticket pour le refonte Pogues
Projects
None yet
Development

No branches or pull requests

2 participants