Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lunatic: insert question business name in question components #924

Open
nsenave opened this issue Mar 7, 2024 · 0 comments
Open

Lunatic: insert question business name in question components #924

nsenave opened this issue Mar 7, 2024 · 0 comments
Assignees
Labels
enhancement Would be good, but non prioritary State: Standby To be done, but later on

Comments

@nsenave
Copy link
Contributor

nsenave commented Mar 7, 2024

Lunatic components that correspond to questions defined in Pogues doesn't hold the information of the business question name.

  • This makes debugging harder.
  • This prevents to make a clear link between "FILTER_RESULT" variables and the component they are associated with. (cf. kraftwerk @loichenninger )

I suggest to add the information in the model, something like:

{
    "id": "foo",
    "componentType": "Input",
    "name": "FOO_QUESTION",
    "response": {
        "name": "FOO_RESPONSE"
    }
}

Proposals: "name" / "questionName" (I prefer the first one since its shorter, yet we have to make sure it doesn't conflict existing properties of Lunatic's model)

Note: In most cases, question business name and response are identical. Yet, in Pogues, nothing prevents the user from changing the question name after having generated the variables. Also, there is the "FILTER_RESULT" link issue for questions with multiple responses.

@nsenave nsenave self-assigned this Mar 7, 2024
@nsenave nsenave added the State: Standby To be done, but later on label Mar 7, 2024
@nsenave nsenave added the enhancement Would be good, but non prioritary label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Would be good, but non prioritary State: Standby To be done, but later on
Projects
None yet
Development

No branches or pull requests

1 participant